search

StanfordSpezi / SpeziFirebase

Google Firebase Spezi Modules
https://swiftpackageindex.com/StanfordSpezi/SpeziFirebase/documentation/
MIT License
4 stars 2 forks source link

Rework FirestoreAccountStorage implementation #25

Closed Supereg closed 11 months ago

Supereg commented 11 months ago

Rework FirestoreAccountStorage implementation

:recycle: Current situation & Problem

This PR fixes several issues identified within #24. As it turns out, we completely forgot to add testing for this component. This follow-up PR addresses some of the issues and adds proper UI testing.

:gear: Release Notes

:books: Documentation

--

:white_check_mark: Testing

We added testing for the respective components.

:pencil: Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

codecov[bot] commented 11 months ago

Codecov Report

Merging #25 (5fb06b7) into main (21419af) will decrease coverage by 0.07%. The diff coverage is 100.00%.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/StanfordSpezi/SpeziFirebase/pull/25/graphs/tree.svg?width=650&height=150&src=pr&token=Z84BufPFgU&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi)](https://app.codecov.io/gh/StanfordSpezi/SpeziFirebase/pull/25?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi) ```diff @@ Coverage Diff @@ ## main #25 +/- ## ========================================== - Coverage 59.99% 59.91% -0.07% ========================================== Files 19 19 Lines 1072 1065 -7 ========================================== - Hits 643 638 -5 + Misses 429 427 -2 ``` | [Files](https://app.codecov.io/gh/StanfordSpezi/SpeziFirebase/pull/25?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi) | Coverage Δ | | |---|---|---| | [...ount/Account Services/FirebaseAccountService.swift](https://app.codecov.io/gh/StanfordSpezi/SpeziFirebase/pull/25?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi#diff-U291cmNlcy9TcGV6aUZpcmViYXNlQWNjb3VudC9BY2NvdW50IFNlcnZpY2VzL0ZpcmViYXNlQWNjb3VudFNlcnZpY2Uuc3dpZnQ=) | `76.55% <100.00%> (-1.86%)` | :arrow_down: | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/StanfordSpezi/SpeziFirebase/pull/25/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/StanfordSpezi/SpeziFirebase/pull/25?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/StanfordSpezi/SpeziFirebase/pull/25?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi). Last update [21419af...5fb06b7](https://app.codecov.io/gh/StanfordSpezi/SpeziFirebase/pull/25?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi).