Closed Supereg closed 2 weeks ago
Attention: Patch coverage is 82.14286%
with 35 lines
in your changes missing coverage. Please review.
Project coverage is 66.76%. Comparing base (
12e7b77
) to head (271753b
). Report is 1 commits behind head on main.
Files with missing lines | Patch % | Lines |
---|---|---|
.../SpeziFirebaseAccount/FirebaseAccountService.swift | 82.15% | 35 Missing :warning: |
Thank you for adding this @Supereg!
Several fixes for the FirebaseAccountService
:recycle: Current situation & Problem
This PR introduces several improvements for the FirebaseAccountService and fixes some bugs and issues. We fixed an issue where the initial account would not be associated correctly and the following stateDidChange call would always be ignored independent if the state actually changed between the initial check and the call. Further, we made minor changes to make sure that no user account is associated when we try to login or signup for a new user account. We previously always relied on the stateDidChange change handler to be called to complete operations like signup/signin/logout/delete. These operations now no longer rely on the stateDidChange listener to be called and instead always propagate their changes themselves.
:gear: Release Notes
:books: Documentation
--
:white_check_mark: Testing
--
:pencil: Code of Conduct & Contributing Guidelines
By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines: