search

StanfordSpezi / SpeziKt

Kotlin & Android Version of the Stanford Spezi Framework
http://spezi.health/SpeziKt/
MIT License
7 stars 1 forks source link

Fix/issue 38 password keyboard behaviour #43

Closed Basler182 closed 2 weeks ago

Basler182 commented 3 weeks ago

Fix/issue 38 password keyboard behaviour

:recycle: Current situation & Problem

38

:gear: Release Notes

:white_check_mark: Testing

:pencil: Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

codecov[bot] commented 3 weeks ago

Codecov Report

Attention: Patch coverage is 15.61644% with 308 lines in your changes missing coverage. Please review.

Project coverage is 27.54%. Comparing base (1f3a66f) to head (0af5247).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/StanfordSpezi/SpeziKt/pull/43/graphs/tree.svg?width=650&height=150&src=pr&token=rrQTC1h5A7&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi)](https://app.codecov.io/gh/StanfordSpezi/SpeziKt/pull/43?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi) ```diff @@ Coverage Diff @@ ## main #43 +/- ## ============================================ + Coverage 25.97% 27.54% +1.58% - Complexity 195 228 +33 ============================================ Files 102 105 +3 Lines 2916 3102 +186 Branches 403 439 +36 ============================================ + Hits 757 854 +97 - Misses 2122 2196 +74 - Partials 37 52 +15 ``` | [Flag](https://app.codecov.io/gh/StanfordSpezi/SpeziKt/pull/43/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/StanfordSpezi/SpeziKt/pull/43/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi) | `27.54% <15.62%> (+1.58%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/StanfordSpezi/SpeziKt/pull/43?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi) | Coverage Δ | | |---|---|---| | [...edu/stanford/spezi/module/account/login/UiState.kt](https://app.codecov.io/gh/StanfordSpezi/SpeziKt/pull/43?src=pr&el=tree&filepath=modules%2Faccount%2Fsrc%2Fmain%2Fkotlin%2Fedu%2Fstanford%2Fspezi%2Fmodule%2Faccount%2Flogin%2FUiState.kt&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi#diff-bW9kdWxlcy9hY2NvdW50L3NyYy9tYWluL2tvdGxpbi9lZHUvc3RhbmZvcmQvc3BlemkvbW9kdWxlL2FjY291bnQvbG9naW4vVWlTdGF0ZS5rdA==) | `100.00% <100.00%> (+100.00%)` | :arrow_up: | | [...d/spezi/module/account/login/LoginFormValidator.kt](https://app.codecov.io/gh/StanfordSpezi/SpeziKt/pull/43?src=pr&el=tree&filepath=modules%2Faccount%2Fsrc%2Fmain%2Fkotlin%2Fedu%2Fstanford%2Fspezi%2Fmodule%2Faccount%2Flogin%2FLoginFormValidator.kt&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi#diff-bW9kdWxlcy9hY2NvdW50L3NyYy9tYWluL2tvdGxpbi9lZHUvc3RhbmZvcmQvc3BlemkvbW9kdWxlL2FjY291bnQvbG9naW4vTG9naW5Gb3JtVmFsaWRhdG9yLmt0) | `66.67% <66.67%> (ø)` | | | [...ord/spezi/module/account/register/FormValidator.kt](https://app.codecov.io/gh/StanfordSpezi/SpeziKt/pull/43?src=pr&el=tree&filepath=modules%2Faccount%2Fsrc%2Fmain%2Fkotlin%2Fedu%2Fstanford%2Fspezi%2Fmodule%2Faccount%2Fregister%2FFormValidator.kt&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi#diff-bW9kdWxlcy9hY2NvdW50L3NyYy9tYWluL2tvdGxpbi9lZHUvc3RhbmZvcmQvc3BlemkvbW9kdWxlL2FjY291bnQvcmVnaXN0ZXIvRm9ybVZhbGlkYXRvci5rdA==) | `90.00% <90.00%> (ø)` | | | [...d/spezi/module/account/register/RegisterUiState.kt](https://app.codecov.io/gh/StanfordSpezi/SpeziKt/pull/43?src=pr&el=tree&filepath=modules%2Faccount%2Fsrc%2Fmain%2Fkotlin%2Fedu%2Fstanford%2Fspezi%2Fmodule%2Faccount%2Fregister%2FRegisterUiState.kt&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi#diff-bW9kdWxlcy9hY2NvdW50L3NyYy9tYWluL2tvdGxpbi9lZHUvc3RhbmZvcmQvc3BlemkvbW9kdWxlL2FjY291bnQvcmVnaXN0ZXIvUmVnaXN0ZXJVaVN0YXRlLmt0) | `93.11% <80.00%> (-2.72%)` | :arrow_down: | | [...n/kotlin/edu/stanford/bdh/engagehf/MainActivity.kt](https://app.codecov.io/gh/StanfordSpezi/SpeziKt/pull/43?src=pr&el=tree&filepath=app%2Fsrc%2Fmain%2Fkotlin%2Fedu%2Fstanford%2Fbdh%2Fengagehf%2FMainActivity.kt&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi#diff-YXBwL3NyYy9tYWluL2tvdGxpbi9lZHUvc3RhbmZvcmQvYmRoL2VuZ2FnZWhmL01haW5BY3Rpdml0eS5rdA==) | `0.00% <0.00%> (ø)` | | | [...account/cred/manager/CredentialLoginManagerAuth.kt](https://app.codecov.io/gh/StanfordSpezi/SpeziKt/pull/43?src=pr&el=tree&filepath=modules%2Faccount%2Fsrc%2Fmain%2Fkotlin%2Fedu%2Fstanford%2Fspezi%2Fmodule%2Faccount%2Fcred%2Fmanager%2FCredentialLoginManagerAuth.kt&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi#diff-bW9kdWxlcy9hY2NvdW50L3NyYy9tYWluL2tvdGxpbi9lZHUvc3RhbmZvcmQvc3BlemkvbW9kdWxlL2FjY291bnQvY3JlZC9tYW5hZ2VyL0NyZWRlbnRpYWxMb2dpbk1hbmFnZXJBdXRoLmt0) | `2.57% <0.00%> (+2.57%)` | :arrow_up: | | [...i/module/account/register/RegisterFormValidator.kt](https://app.codecov.io/gh/StanfordSpezi/SpeziKt/pull/43?src=pr&el=tree&filepath=modules%2Faccount%2Fsrc%2Fmain%2Fkotlin%2Fedu%2Fstanford%2Fspezi%2Fmodule%2Faccount%2Fregister%2FRegisterFormValidator.kt&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi#diff-bW9kdWxlcy9hY2NvdW50L3NyYy9tYWluL2tvdGxpbi9lZHUvc3RhbmZvcmQvc3BlemkvbW9kdWxlL2FjY291bnQvcmVnaXN0ZXIvUmVnaXN0ZXJGb3JtVmFsaWRhdG9yLmt0) | `21.74% <7.15%> (-14.26%)` | :arrow_down: | | [...ed/outlinedtextfield/ValidatedOutlinedTextField.kt](https://app.codecov.io/gh/StanfordSpezi/SpeziKt/pull/43?src=pr&el=tree&filepath=core%2Fdesign%2Fsrc%2Fmain%2Fkotlin%2Fedu%2Fstanford%2Fspezi%2Fcore%2Fdesign%2Fcomponent%2Fvalidated%2Foutlinedtextfield%2FValidatedOutlinedTextField.kt&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi#diff-Y29yZS9kZXNpZ24vc3JjL21haW4va290bGluL2VkdS9zdGFuZm9yZC9zcGV6aS9jb3JlL2Rlc2lnbi9jb21wb25lbnQvdmFsaWRhdGVkL291dGxpbmVkdGV4dGZpZWxkL1ZhbGlkYXRlZE91dGxpbmVkVGV4dEZpZWxkLmt0) | `0.00% <0.00%> (ø)` | | | [...spezi/module/account/register/RegisterViewModel.kt](https://app.codecov.io/gh/StanfordSpezi/SpeziKt/pull/43?src=pr&el=tree&filepath=modules%2Faccount%2Fsrc%2Fmain%2Fkotlin%2Fedu%2Fstanford%2Fspezi%2Fmodule%2Faccount%2Fregister%2FRegisterViewModel.kt&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi#diff-bW9kdWxlcy9hY2NvdW50L3NyYy9tYWluL2tvdGxpbi9lZHUvc3RhbmZvcmQvc3BlemkvbW9kdWxlL2FjY291bnQvcmVnaXN0ZXIvUmVnaXN0ZXJWaWV3TW9kZWwua3Q=) | `28.04% <45.17%> (+5.42%)` | :arrow_up: | | [...nford/spezi/module/account/login/LoginViewModel.kt](https://app.codecov.io/gh/StanfordSpezi/SpeziKt/pull/43?src=pr&el=tree&filepath=modules%2Faccount%2Fsrc%2Fmain%2Fkotlin%2Fedu%2Fstanford%2Fspezi%2Fmodule%2Faccount%2Flogin%2FLoginViewModel.kt&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi#diff-bW9kdWxlcy9hY2NvdW50L3NyYy9tYWluL2tvdGxpbi9lZHUvc3RhbmZvcmQvc3BlemkvbW9kdWxlL2FjY291bnQvbG9naW4vTG9naW5WaWV3TW9kZWwua3Q=) | `40.00% <41.82%> (+40.00%)` | :arrow_up: | | ... and [3 more](https://app.codecov.io/gh/StanfordSpezi/SpeziKt/pull/43?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi) | | ... and [3 files with indirect coverage changes](https://app.codecov.io/gh/StanfordSpezi/SpeziKt/pull/43/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/StanfordSpezi/SpeziKt/pull/43?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/StanfordSpezi/SpeziKt/pull/43?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi). Last update [1f3a66f...0af5247](https://app.codecov.io/gh/StanfordSpezi/SpeziKt/pull/43?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi).
PSchmiedmayer commented 3 weeks ago

Thank you for taking a look at this and fixing the issues in smaller targeted PRs @Basler182 🚀 I will defer to @eldcn or @pauljohanneskraft for an in-depth review of the changes.