StanfordSpezi / SpeziKt

Kotlin & Android Version of the Stanford Spezi Framework
http://spezi.health/SpeziKt/
MIT License
7 stars 1 forks source link

Fix/issue 32 leading aligned icons register #44

Closed Basler182 closed 2 weeks ago

Basler182 commented 3 weeks ago

Fix/issue 32 leading aligned icons register

Could be either merged into #43 or main once #43 is merged

:recycle: Current situation & Problem

32

:gear: Release Notes

:pencil: Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

PSchmiedmayer commented 3 weeks ago

Thank you for working on these issues @Basler182 🚀

codecov[bot] commented 3 weeks ago

Codecov Report

Attention: Patch coverage is 0% with 110 lines in your changes missing coverage. Please review.

Project coverage is 21.81%. Comparing base (decf4e3) to head (fadf827).

:exclamation: Current head fadf827 differs from pull request most recent head 10fed37

Please upload reports for the commit 10fed37 to get more accurate results.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/StanfordSpezi/SpeziKt/pull/44/graphs/tree.svg?width=650&height=150&src=pr&token=rrQTC1h5A7&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi)](https://app.codecov.io/gh/StanfordSpezi/SpeziKt/pull/44?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi) ```diff @@ Coverage Diff @@ ## fix/issue-38-password-keyboard-behaviour #44 +/- ## ============================================================================== - Coverage 22.19% 21.81% -0.38% Complexity 182 182 ============================================================================== Files 101 102 +1 Lines 2673 2720 +47 Branches 404 412 +8 ============================================================================== Hits 593 593 - Misses 2025 2072 +47 Partials 55 55 ``` | [Flag](https://app.codecov.io/gh/StanfordSpezi/SpeziKt/pull/44/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/StanfordSpezi/SpeziKt/pull/44/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi) | `21.81% <0.00%> (-0.38%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/StanfordSpezi/SpeziKt/pull/44?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi) | Coverage Δ | | |---|---|---| | [...pezi/module/account/register/IconLeadingContent.kt](https://app.codecov.io/gh/StanfordSpezi/SpeziKt/pull/44?src=pr&el=tree&filepath=modules%2Faccount%2Fsrc%2Fmain%2Fkotlin%2Fedu%2Fstanford%2Fspezi%2Fmodule%2Faccount%2Fregister%2FIconLeadingContent.kt&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi#diff-bW9kdWxlcy9hY2NvdW50L3NyYy9tYWluL2tvdGxpbi9lZHUvc3RhbmZvcmQvc3BlemkvbW9kdWxlL2FjY291bnQvcmVnaXN0ZXIvSWNvbkxlYWRpbmdDb250ZW50Lmt0) | `0.00% <0.00%> (ø)` | | | [...rd/spezi/module/account/register/RegisterScreen.kt](https://app.codecov.io/gh/StanfordSpezi/SpeziKt/pull/44?src=pr&el=tree&filepath=modules%2Faccount%2Fsrc%2Fmain%2Fkotlin%2Fedu%2Fstanford%2Fspezi%2Fmodule%2Faccount%2Fregister%2FRegisterScreen.kt&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi#diff-bW9kdWxlcy9hY2NvdW50L3NyYy9tYWluL2tvdGxpbi9lZHUvc3RhbmZvcmQvc3BlemkvbW9kdWxlL2FjY291bnQvcmVnaXN0ZXIvUmVnaXN0ZXJTY3JlZW4ua3Q=) | `0.00% <0.00%> (ø)` | | ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/StanfordSpezi/SpeziKt/pull/44?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/StanfordSpezi/SpeziKt/pull/44?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi). Last update [decf4e3...10fed37](https://app.codecov.io/gh/StanfordSpezi/SpeziKt/pull/44?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi).
Basler182 commented 3 weeks ago

image @PSchmiedmayer