PSchmiedmayer commented 2 weeks ago

Setup Android Tests CI Setup

:recycle: Current situation & Problem

Addresses #16
Closes #21

:gear: Release Notes

Setup Android Tests CI Setup

☑️ Remaining Issues

[x] Report Code Coverage: I have build the rough setup for running the tests but the code coverage report currently doesn't work as expected for the Android tests. Codecov seems to merge reports for the same commit so we can just upload them all in different builds. Would be amazing if you can take a look at this @eldcn
[x] Contact Tests Fail: It seems like the contact Android tests fail locally and on the CI. Good as a test for the setup, would be great if we can fix them as part of this PR @Basler182

:pencil: Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

[x] I agree to follow the Code of Conduct and Contributing Guidelines.

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 41.99%. Comparing base (19b0573) to head (6dfb0eb).

Additional details and impacted files

[![Impacted file tree graph](https://app.codecov.io/gh/StanfordSpezi/SpeziKt/pull/48/graphs/tree.svg?width=650&height=150&src=pr&token=rrQTC1h5A7&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi)](https://app.codecov.io/gh/StanfordSpezi/SpeziKt/pull/48?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi) ```diff @@ Coverage Diff @@ ## main #48 +/- ## ============================================= + Coverage 27.54% 41.99% +14.46% - Complexity 228 296 +68 ============================================= Files 105 111 +6 Lines 3102 3227 +125 Branches 439 470 +31 ============================================= + Hits 854 1355 +501 + Misses 2196 1770 -426 - Partials 52 102 +50 ``` | [Flag](https://app.codecov.io/gh/StanfordSpezi/SpeziKt/pull/48/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi) | Coverage Δ | | |---|---|---| | [uitests](https://app.codecov.io/gh/StanfordSpezi/SpeziKt/pull/48/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi) | `33.48% <ø> (?)` | | | [unittests](https://app.codecov.io/gh/StanfordSpezi/SpeziKt/pull/48/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi) | `27.56% <100.00%> (+0.03%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/StanfordSpezi/SpeziKt/pull/48?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi) | Coverage Δ | | |---|---|---| | [...rd/spezi/core/bluetooth/domain/BLEDeviceScanner.kt](https://app.codecov.io/gh/StanfordSpezi/SpeziKt/pull/48?src=pr&el=tree&filepath=core%2Fbluetooth%2Fsrc%2Fmain%2Fkotlin%2Fedu%2Fstanford%2Fspezi%2Fcore%2Fbluetooth%2Fdomain%2FBLEDeviceScanner.kt&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi#diff-Y29yZS9ibHVldG9vdGgvc3JjL21haW4va290bGluL2VkdS9zdGFuZm9yZC9zcGV6aS9jb3JlL2JsdWV0b290aC9kb21haW4vQkxFRGV2aWNlU2Nhbm5lci5rdA==) | `96.78% <100.00%> (+0.11%)` | :arrow_up: | ... and [26 files with indirect coverage changes](https://app.codecov.io/gh/StanfordSpezi/SpeziKt/pull/48/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/StanfordSpezi/SpeziKt/pull/48?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/StanfordSpezi/SpeziKt/pull/48?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi). Last update [19b0573...6dfb0eb](https://app.codecov.io/gh/StanfordSpezi/SpeziKt/pull/48?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi).

PSchmiedmayer commented 2 weeks ago

Thank you @eldcn for the amazing work to finish this PR up and thanks for the feedback and suggestions. I improved the state based on your feedback and provided some reasoning about some for the GitHub action setup.

Will merge this PR for now but happy to continue parts of the discussion here or in separate GitHub issues if there is still something to follow up on this PR 🚀

StanfordSpezi / SpeziKt