search

StanfordSpezi / SpeziKt

Kotlin & Android Version of the Stanford Spezi Framework
http://spezi.health/SpeziKt/
MIT License
8 stars 2 forks source link

Feature/issue 37 firebase dependencies #55

Closed eldcn closed 3 months ago

eldcn commented 3 months ago

Firebase dependencies in Account module

:recycle: Current situation & Problem

Moves all firebase dependencies in account module, and exposes needed information and APIs from other modules via custom components. This way, consumers of account module, do not need to include firebase dependencies additionally in case they use account. Firebase remains this way as an internal implementation detail, that can be easily replaced without affecting other modules and minimizing breaking changes in regard to backwards compatibility

:gear: Release Notes

Add a bullet point list summary of the feature and possible migration guides if this is a breaking change so this section can be added to the release notes. Include code snippets that provide examples of the feature implemented or links to the documentation if it appends or changes the public interface.

:books: Documentation

Please ensure that you properly document any additions in conformance to Spezi Documentation Guide. You can use this section to describe your solution, but we encourage contributors to document your reasoning and changes using in-line documentation.

:white_check_mark: Testing

Please ensure that the PR meets the testing requirements set by CodeCov and that new functionality is appropriately tested. This section describes important information about the tests and why some elements might not be testable.

:pencil: Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 22.22222% with 28 lines in your changes missing coverage. Please review.

Project coverage is 33.90%. Comparing base (b7ec2db) to head (0485332).

:exclamation: There is a different number of reports uploaded between BASE (b7ec2db) and HEAD (0485332). Click for more details.

HEAD has 1 upload less than BASE | Flag | BASE (b7ec2db) | HEAD (0485332) | |------|------|------| |unittests|1|0|
Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/StanfordSpezi/SpeziKt/pull/55/graphs/tree.svg?width=650&height=150&src=pr&token=rrQTC1h5A7&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi)](https://app.codecov.io/gh/StanfordSpezi/SpeziKt/pull/55?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi) ```diff @@ Coverage Diff @@ ## feature/issue-37 #55 +/- ## ====================================================== - Coverage 42.01% 33.90% -8.10% + Complexity 299 86 -213 ====================================================== Files 111 63 -48 Lines 3252 1658 -1594 Branches 475 246 -229 ====================================================== - Hits 1366 562 -804 + Misses 1782 1037 -745 + Partials 104 59 -45 ``` | [Flag](https://app.codecov.io/gh/StanfordSpezi/SpeziKt/pull/55/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi) | Coverage Δ | | |---|---|---| | [uitests](https://app.codecov.io/gh/StanfordSpezi/SpeziKt/pull/55/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi) | `33.90% <22.23%> (+0.51%)` | :arrow_up: | | [unittests](https://app.codecov.io/gh/StanfordSpezi/SpeziKt/pull/55/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/StanfordSpezi/SpeziKt/pull/55?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi) | Coverage Δ | | |---|---|---| | [...e/onboarding/invitation/InvitationCodeViewModel.kt](https://app.codecov.io/gh/StanfordSpezi/SpeziKt/pull/55?src=pr&el=tree&filepath=modules%2Fonboarding%2Fsrc%2Fmain%2Fkotlin%2Fedu%2Fstanford%2Fspezi%2Fmodule%2Fonboarding%2Finvitation%2FInvitationCodeViewModel.kt&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi#diff-bW9kdWxlcy9vbmJvYXJkaW5nL3NyYy9tYWluL2tvdGxpbi9lZHUvc3RhbmZvcmQvc3BlemkvbW9kdWxlL29uYm9hcmRpbmcvaW52aXRhdGlvbi9JbnZpdGF0aW9uQ29kZVZpZXdNb2RlbC5rdA==) | `0.00% <ø> (-66.66%)` | :arrow_down: | | [...zi/module/onboarding/consent/PdfCreationService.kt](https://app.codecov.io/gh/StanfordSpezi/SpeziKt/pull/55?src=pr&el=tree&filepath=modules%2Fonboarding%2Fsrc%2Fmain%2Fkotlin%2Fedu%2Fstanford%2Fspezi%2Fmodule%2Fonboarding%2Fconsent%2FPdfCreationService.kt&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi#diff-bW9kdWxlcy9vbmJvYXJkaW5nL3NyYy9tYWluL2tvdGxpbi9lZHUvc3RhbmZvcmQvc3BlemkvbW9kdWxlL29uYm9hcmRpbmcvY29uc2VudC9QZGZDcmVhdGlvblNlcnZpY2Uua3Q=) | `0.00% <0.00%> (ø)` | | | [...rd/bdh/engagehf/onboarding/EngageConsentManager.kt](https://app.codecov.io/gh/StanfordSpezi/SpeziKt/pull/55?src=pr&el=tree&filepath=app%2Fsrc%2Fmain%2Fkotlin%2Fedu%2Fstanford%2Fbdh%2Fengagehf%2Fonboarding%2FEngageConsentManager.kt&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi#diff-YXBwL3NyYy9tYWluL2tvdGxpbi9lZHUvc3RhbmZvcmQvYmRoL2VuZ2FnZWhmL29uYm9hcmRpbmcvRW5nYWdlQ29uc2VudE1hbmFnZXIua3Q=) | `71.43% <33.34%> (+16.89%)` | :arrow_up: | | [...edu/stanford/bdh/engagehf/MainActivityViewModel.kt](https://app.codecov.io/gh/StanfordSpezi/SpeziKt/pull/55?src=pr&el=tree&filepath=app%2Fsrc%2Fmain%2Fkotlin%2Fedu%2Fstanford%2Fbdh%2Fengagehf%2FMainActivityViewModel.kt&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi#diff-YXBwL3NyYy9tYWluL2tvdGxpbi9lZHUvc3RhbmZvcmQvYmRoL2VuZ2FnZWhmL01haW5BY3Rpdml0eVZpZXdNb2RlbC5rdA==) | `65.22% <63.64%> (-11.70%)` | :arrow_down: | | [...pezi/module/onboarding/consent/ConsentViewModel.kt](https://app.codecov.io/gh/StanfordSpezi/SpeziKt/pull/55?src=pr&el=tree&filepath=modules%2Fonboarding%2Fsrc%2Fmain%2Fkotlin%2Fedu%2Fstanford%2Fspezi%2Fmodule%2Fonboarding%2Fconsent%2FConsentViewModel.kt&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi#diff-bW9kdWxlcy9vbmJvYXJkaW5nL3NyYy9tYWluL2tvdGxpbi9lZHUvc3RhbmZvcmQvc3BlemkvbW9kdWxlL29uYm9hcmRpbmcvY29uc2VudC9Db25zZW50Vmlld01vZGVsLmt0) | `0.00% <0.00%> (-70.37%)` | :arrow_down: | ... and [55 files with indirect coverage changes](https://app.codecov.io/gh/StanfordSpezi/SpeziKt/pull/55/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/StanfordSpezi/SpeziKt/pull/55?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/StanfordSpezi/SpeziKt/pull/55?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi). Last update [b7ec2db...0485332](https://app.codecov.io/gh/StanfordSpezi/SpeziKt/pull/55?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi).