StanfordSpezi / SpeziKt

Kotlin & Android Version of the Stanford Spezi Framework
http://spezi.health/SpeziKt/
MIT License
8 stars 1 forks source link

Adds Android FHIR SDK for data capture #64

Closed vishnuravi closed 1 month ago

vishnuravi commented 1 month ago

Adds Android FHIR SDK for data capture

:gear: Release Notes

This PR adds the Android FHIR SDK's data capture module which provides functionality for rendering FHIR Questionnaires and FHIR data types for HealthConnectOnFHIR.

:pencil: Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 44.61%. Comparing base (d2701ef) to head (36e03eb).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/StanfordSpezi/SpeziKt/pull/64/graphs/tree.svg?width=650&height=150&src=pr&token=rrQTC1h5A7&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi)](https://app.codecov.io/gh/StanfordSpezi/SpeziKt/pull/64?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi) ```diff @@ Coverage Diff @@ ## main #64 +/- ## ========================================= Coverage 44.61% 44.61% Complexity 318 318 ========================================= Files 125 125 Lines 3829 3829 Branches 558 558 ========================================= Hits 1708 1708 Misses 1970 1970 Partials 151 151 ``` | [Flag](https://app.codecov.io/gh/StanfordSpezi/SpeziKt/pull/64/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi) | Coverage Δ | | |---|---|---| | [uitests](https://app.codecov.io/gh/StanfordSpezi/SpeziKt/pull/64/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi) | `35.90% <ø> (ø)` | | | [unittests](https://app.codecov.io/gh/StanfordSpezi/SpeziKt/pull/64/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi) | `28.25% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi#carryforward-flags-in-the-pull-request-comment) to find out more. ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/StanfordSpezi/SpeziKt/pull/64?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/StanfordSpezi/SpeziKt/pull/64?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi). Last update [d2701ef...36e03eb](https://app.codecov.io/gh/StanfordSpezi/SpeziKt/pull/64?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi).
eldcn commented 1 month ago

Not quite sure why the diff is so large; shouldn't this just be a small addition to feature/messages?

I noticed that this branch has been created from main in later state compared to feature/save-measurements. I just pushed the needed changes in #53 directly at this commit, we can observe next if the jacocco issue get's resolved (then we can close this PR in favor of #53). If not, we can temporarily disable coverage report and address in a smaller follow up. CC: @PSchmiedmayer @vishnuravi @Basler182

PSchmiedmayer commented 1 month ago

Thank you @eldcn for the context!