search

StanfordSpezi / SpeziKt

Kotlin & Android Version of the Stanford Spezi Framework
http://spezi.health/SpeziKt/
MIT License
8 stars 2 forks source link

Some review comments from Save measurements #68

Closed eldcn closed 2 months ago

eldcn commented 2 months ago

Some open PR review comments

:recycle: Current situation & Problem

:gear: Release Notes

Add a bullet point list summary of the feature and possible migration guides if this is a breaking change so this section can be added to the release notes. Include code snippets that provide examples of the feature implemented or links to the documentation if it appends or changes the public interface.

:books: Documentation

Please ensure that you properly document any additions in conformance to Spezi Documentation Guide. You can use this section to describe your solution, but we encourage contributors to document your reasoning and changes using in-line documentation.

:white_check_mark: Testing

Please ensure that the PR meets the testing requirements set by CodeCov and that new functionality is appropriately tested. This section describes important information about the tests and why some elements might not be testable.

:pencil: Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 93.10345% with 10 lines in your changes missing coverage. Please review.

Project coverage is 39.16%. Comparing base (7757129) to head (a188161).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/StanfordSpezi/SpeziKt/pull/68/graphs/tree.svg?width=650&height=150&src=pr&token=rrQTC1h5A7&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi)](https://app.codecov.io/gh/StanfordSpezi/SpeziKt/pull/68?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi) ```diff @@ Coverage Diff @@ ## main #68 +/- ## ============================================ + Coverage 36.32% 39.16% +2.85% - Complexity 335 379 +44 ============================================ Files 140 140 Lines 4792 4738 -54 Branches 676 667 -9 ============================================ + Hits 1740 1855 +115 + Misses 2892 2720 -172 - Partials 160 163 +3 ``` | [Flag](https://app.codecov.io/gh/StanfordSpezi/SpeziKt/pull/68/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi) | Coverage Δ | | |---|---|---| | [uitests](https://app.codecov.io/gh/StanfordSpezi/SpeziKt/pull/68/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi) | `29.04% <ø> (ø)` | | | [unittests](https://app.codecov.io/gh/StanfordSpezi/SpeziKt/pull/68/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi) | `29.97% <93.11%> (+2.80%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/StanfordSpezi/SpeziKt/pull/68?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi) | Coverage Δ | | |---|---|---| | [...tanford/bdh/engagehf/messages/MessageRepository.kt](https://app.codecov.io/gh/StanfordSpezi/SpeziKt/pull/68?src=pr&el=tree&filepath=app%2Fsrc%2Fmain%2Fkotlin%2Fedu%2Fstanford%2Fbdh%2Fengagehf%2Fmessages%2FMessageRepository.kt&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi#diff-YXBwL3NyYy9tYWluL2tvdGxpbi9lZHUvc3RhbmZvcmQvYmRoL2VuZ2FnZWhmL21lc3NhZ2VzL01lc3NhZ2VSZXBvc2l0b3J5Lmt0) | `61.54% <ø> (+58.98%)` | :arrow_up: | | [...u/stanford/bdh/engagehf/messages/MessagesAction.kt](https://app.codecov.io/gh/StanfordSpezi/SpeziKt/pull/68?src=pr&el=tree&filepath=app%2Fsrc%2Fmain%2Fkotlin%2Fedu%2Fstanford%2Fbdh%2Fengagehf%2Fmessages%2FMessagesAction.kt&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi#diff-YXBwL3NyYy9tYWluL2tvdGxpbi9lZHUvc3RhbmZvcmQvYmRoL2VuZ2FnZWhmL21lc3NhZ2VzL01lc3NhZ2VzQWN0aW9uLmt0) | `100.00% <100.00%> (ø)` | | | [...nford/bdh/engagehf/navigation/screens/AppScreen.kt](https://app.codecov.io/gh/StanfordSpezi/SpeziKt/pull/68?src=pr&el=tree&filepath=app%2Fsrc%2Fmain%2Fkotlin%2Fedu%2Fstanford%2Fbdh%2Fengagehf%2Fnavigation%2Fscreens%2FAppScreen.kt&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi#diff-YXBwL3NyYy9tYWluL2tvdGxpbi9lZHUvc3RhbmZvcmQvYmRoL2VuZ2FnZWhmL25hdmlnYXRpb24vc2NyZWVucy9BcHBTY3JlZW4ua3Q=) | `0.00% <0.00%> (ø)` | | | [...nford/bdh/engagehf/bluetooth/BluetoothViewModel.kt](https://app.codecov.io/gh/StanfordSpezi/SpeziKt/pull/68?src=pr&el=tree&filepath=app%2Fsrc%2Fmain%2Fkotlin%2Fedu%2Fstanford%2Fbdh%2Fengagehf%2Fbluetooth%2FBluetoothViewModel.kt&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi#diff-YXBwL3NyYy9tYWluL2tvdGxpbi9lZHUvc3RhbmZvcmQvYmRoL2VuZ2FnZWhmL2JsdWV0b290aC9CbHVldG9vdGhWaWV3TW9kZWwua3Q=) | `95.58% <91.49%> (+53.10%)` | :arrow_up: | | [...hf/bluetooth/data/mapper/BluetoothUiStateMapper.kt](https://app.codecov.io/gh/StanfordSpezi/SpeziKt/pull/68?src=pr&el=tree&filepath=app%2Fsrc%2Fmain%2Fkotlin%2Fedu%2Fstanford%2Fbdh%2Fengagehf%2Fbluetooth%2Fdata%2Fmapper%2FBluetoothUiStateMapper.kt&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi#diff-YXBwL3NyYy9tYWluL2tvdGxpbi9lZHUvc3RhbmZvcmQvYmRoL2VuZ2FnZWhmL2JsdWV0b290aC9kYXRhL21hcHBlci9CbHVldG9vdGhVaVN0YXRlTWFwcGVyLmt0) | `94.22% <94.45%> (+54.22%)` | :arrow_up: | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/StanfordSpezi/SpeziKt/pull/68/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/StanfordSpezi/SpeziKt/pull/68?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/StanfordSpezi/SpeziKt/pull/68?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi). Last update [7757129...a188161](https://app.codecov.io/gh/StanfordSpezi/SpeziKt/pull/68?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi).