StanfordSpezi / SpeziKt

Kotlin & Android Version of the Stanford Spezi Framework
http://spezi.health/SpeziKt/
MIT License
8 stars 1 forks source link

adjust firestore security rules from users to patients #69

Closed Basler182 closed 1 month ago

Basler182 commented 1 month ago

adjust firestore security rules from users to patients

:recycle: Current situation & Problem

Adapt FirebaseStorage Rules for users->patients renaming PR Add security

:pencil: Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 60.00000% with 12 lines in your changes missing coverage. Please review.

Project coverage is 39.24%. Comparing base (fe29b50) to head (7f61a68).

Files Patch % Lines
...zi/module/account/manager/AuthenticationManager.kt 0.00% 7 Missing :warning:
...rd/spezi/module/account/register/RegisterScreen.kt 0.00% 3 Missing :warning:
...i/module/account/register/RegisterFormValidator.kt 0.00% 1 Missing :warning:
...d/spezi/module/account/register/RegisterUiState.kt 87.50% 1 Missing :warning:
Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/StanfordSpezi/SpeziKt/pull/69/graphs/tree.svg?width=650&height=150&src=pr&token=rrQTC1h5A7&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi)](https://app.codecov.io/gh/StanfordSpezi/SpeziKt/pull/69?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi) ```diff @@ Coverage Diff @@ ## main #69 +/- ## ============================================ + Coverage 39.16% 39.24% +0.09% Complexity 379 379 ============================================ Files 140 140 Lines 4738 4743 +5 Branches 667 667 ============================================ + Hits 1855 1861 +6 + Misses 2720 2719 -1 Partials 163 163 ``` | [Flag](https://app.codecov.io/gh/StanfordSpezi/SpeziKt/pull/69/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi) | Coverage Δ | | |---|---|---| | [uitests](https://app.codecov.io/gh/StanfordSpezi/SpeziKt/pull/69/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi) | `29.04% <ø> (ø)` | | | [unittests](https://app.codecov.io/gh/StanfordSpezi/SpeziKt/pull/69/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi) | `30.07% <60.00%> (+0.10%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/StanfordSpezi/SpeziKt/pull/69?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi) | Coverage Δ | | |---|---|---| | [...spezi/module/account/manager/UserSessionManager.kt](https://app.codecov.io/gh/StanfordSpezi/SpeziKt/pull/69?src=pr&el=tree&filepath=modules%2Faccount%2Fsrc%2Fmain%2Fkotlin%2Fedu%2Fstanford%2Fspezi%2Fmodule%2Faccount%2Fmanager%2FUserSessionManager.kt&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi#diff-bW9kdWxlcy9hY2NvdW50L3NyYy9tYWluL2tvdGxpbi9lZHUvc3RhbmZvcmQvc3BlemkvbW9kdWxlL2FjY291bnQvbWFuYWdlci9Vc2VyU2Vzc2lvbk1hbmFnZXIua3Q=) | `100.00% <100.00%> (ø)` | | | [...i/module/account/register/RegisterFormValidator.kt](https://app.codecov.io/gh/StanfordSpezi/SpeziKt/pull/69?src=pr&el=tree&filepath=modules%2Faccount%2Fsrc%2Fmain%2Fkotlin%2Fedu%2Fstanford%2Fspezi%2Fmodule%2Faccount%2Fregister%2FRegisterFormValidator.kt&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi#diff-bW9kdWxlcy9hY2NvdW50L3NyYy9tYWluL2tvdGxpbi9lZHUvc3RhbmZvcmQvc3BlemkvbW9kdWxlL2FjY291bnQvcmVnaXN0ZXIvUmVnaXN0ZXJGb3JtVmFsaWRhdG9yLmt0) | `26.32% <0.00%> (+4.58%)` | :arrow_up: | | [...d/spezi/module/account/register/RegisterUiState.kt](https://app.codecov.io/gh/StanfordSpezi/SpeziKt/pull/69?src=pr&el=tree&filepath=modules%2Faccount%2Fsrc%2Fmain%2Fkotlin%2Fedu%2Fstanford%2Fspezi%2Fmodule%2Faccount%2Fregister%2FRegisterUiState.kt&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi#diff-bW9kdWxlcy9hY2NvdW50L3NyYy9tYWluL2tvdGxpbi9lZHUvc3RhbmZvcmQvc3BlemkvbW9kdWxlL2FjY291bnQvcmVnaXN0ZXIvUmVnaXN0ZXJVaVN0YXRlLmt0) | `91.67% <87.50%> (-1.43%)` | :arrow_down: | | [...rd/spezi/module/account/register/RegisterScreen.kt](https://app.codecov.io/gh/StanfordSpezi/SpeziKt/pull/69?src=pr&el=tree&filepath=modules%2Faccount%2Fsrc%2Fmain%2Fkotlin%2Fedu%2Fstanford%2Fspezi%2Fmodule%2Faccount%2Fregister%2FRegisterScreen.kt&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi#diff-bW9kdWxlcy9hY2NvdW50L3NyYy9tYWluL2tvdGxpbi9lZHUvc3RhbmZvcmQvc3BlemkvbW9kdWxlL2FjY291bnQvcmVnaXN0ZXIvUmVnaXN0ZXJTY3JlZW4ua3Q=) | `0.00% <0.00%> (ø)` | | | [...zi/module/account/manager/AuthenticationManager.kt](https://app.codecov.io/gh/StanfordSpezi/SpeziKt/pull/69?src=pr&el=tree&filepath=modules%2Faccount%2Fsrc%2Fmain%2Fkotlin%2Fedu%2Fstanford%2Fspezi%2Fmodule%2Faccount%2Fmanager%2FAuthenticationManager.kt&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi#diff-bW9kdWxlcy9hY2NvdW50L3NyYy9tYWluL2tvdGxpbi9lZHUvc3RhbmZvcmQvc3BlemkvbW9kdWxlL2FjY291bnQvbWFuYWdlci9BdXRoZW50aWNhdGlvbk1hbmFnZXIua3Q=) | `1.73% <0.00%> (-0.03%)` | :arrow_down: | ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/StanfordSpezi/SpeziKt/pull/69?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/StanfordSpezi/SpeziKt/pull/69?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi). Last update [fe29b50...7f61a68](https://app.codecov.io/gh/StanfordSpezi/SpeziKt/pull/69?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi).