StanfordSpezi / SpeziOnboarding

Spezi Onboarding module to inform a user or retrieve consent for a study participation
https://swiftpackageindex.com/StanfordSpezi/SpeziOnboarding/documentation/
MIT License
11 stars 5 forks source link

Improve Localization & Update to Spezi Views #13

Closed PSchmiedmayer closed 10 months ago

PSchmiedmayer commented 10 months ago

Improve Localization & Update to Spezi Views

:recycle: Current situation & Problem

:bulb: Proposed solution

Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

codecov[bot] commented 10 months ago

Codecov Report

Merging #13 (b69edb7) into main (4d4e26d) will decrease coverage by 4.15%. The diff coverage is 55.41%.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/StanfordSpezi/SpeziOnboarding/pull/13/graphs/tree.svg?width=650&height=150&src=pr&token=tVwIFVPdJG&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi)](https://app.codecov.io/gh/StanfordSpezi/SpeziOnboarding/pull/13?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi) ```diff @@ Coverage Diff @@ ## main #13 +/- ## ========================================== - Coverage 77.91% 73.75% -4.15% ========================================== Files 14 14 Lines 706 758 +52 ========================================== + Hits 550 559 +9 - Misses 156 199 +43 ``` | [Files Changed](https://app.codecov.io/gh/StanfordSpezi/SpeziOnboarding/pull/13?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi) | Coverage Δ | | |---|---|---| | [...ources/SpeziOnboarding/OnboardingActionsView.swift](https://app.codecov.io/gh/StanfordSpezi/SpeziOnboarding/pull/13?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi#diff-U291cmNlcy9TcGV6aU9uYm9hcmRpbmcvT25ib2FyZGluZ0FjdGlvbnNWaWV3LnN3aWZ0) | `43.11% <28.58%> (-3.70%)` | :arrow_down: | | [Sources/SpeziOnboarding/OnboardingTitleView.swift](https://app.codecov.io/gh/StanfordSpezi/SpeziOnboarding/pull/13?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi#diff-U291cmNlcy9TcGV6aU9uYm9hcmRpbmcvT25ib2FyZGluZ1RpdGxlVmlldy5zd2lmdA==) | `66.67% <50.00%> (-6.41%)` | :arrow_down: | | [Sources/SpeziOnboarding/OnboardingView.swift](https://app.codecov.io/gh/StanfordSpezi/SpeziOnboarding/pull/13?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi#diff-U291cmNlcy9TcGV6aU9uYm9hcmRpbmcvT25ib2FyZGluZ1ZpZXcuc3dpZnQ=) | `52.50% <50.00%> (-28.26%)` | :arrow_down: | | [...ces/SpeziOnboarding/SequentialOnboardingView.swift](https://app.codecov.io/gh/StanfordSpezi/SpeziOnboarding/pull/13?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi#diff-U291cmNlcy9TcGV6aU9uYm9hcmRpbmcvU2VxdWVudGlhbE9uYm9hcmRpbmdWaWV3LnN3aWZ0) | `81.99% <66.67%> (-2.27%)` | :arrow_down: | | [Sources/SpeziOnboarding/ConsentView.swift](https://app.codecov.io/gh/StanfordSpezi/SpeziOnboarding/pull/13?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi#diff-U291cmNlcy9TcGV6aU9uYm9hcmRpbmcvQ29uc2VudFZpZXcuc3dpZnQ=) | `88.47% <100.00%> (ø)` | | | [...es/SpeziOnboarding/OnboardingInformationView.swift](https://app.codecov.io/gh/StanfordSpezi/SpeziOnboarding/pull/13?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi#diff-U291cmNlcy9TcGV6aU9uYm9hcmRpbmcvT25ib2FyZGluZ0luZm9ybWF0aW9uVmlldy5zd2lmdA==) | `50.71% <100.00%> (+2.18%)` | :arrow_up: | ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/StanfordSpezi/SpeziOnboarding/pull/13?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/StanfordSpezi/SpeziOnboarding/pull/13?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi). Last update [4d4e26d...b69edb7](https://app.codecov.io/gh/StanfordSpezi/SpeziOnboarding/pull/13?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi).