search

StanfordSpezi / SpeziOnboarding

Spezi Onboarding module to inform a user or retrieve consent for a study participation
https://swiftpackageindex.com/StanfordSpezi/SpeziOnboarding/documentation/
MIT License
11 stars 5 forks source link

Optimize accessibility of Onboarding Views #23

Closed Supereg closed 9 months ago

Supereg commented 9 months ago

Optimize accessibility of Onboarding Views

:recycle: Current situation & Problem

Currently, SpeziOnboarding isn't built with accessibility in mind. This PR makes the initial steps to make the onboarding views accessible and optimize VoiceOver navigation.

:gear: Release Notes

:books: Documentation

No changes here

:white_check_mark: Testing

Tests were adjusted where necessary.

:pencil: Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

codecov[bot] commented 9 months ago

Codecov Report

Merging #23 (4b8c228) into main (91a61c7) will increase coverage by 0.42%. The diff coverage is 78.79%.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/StanfordSpezi/SpeziOnboarding/pull/23/graphs/tree.svg?width=650&height=150&src=pr&token=tVwIFVPdJG&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi)](https://app.codecov.io/gh/StanfordSpezi/SpeziOnboarding/pull/23?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi) ```diff @@ Coverage Diff @@ ## main #23 +/- ## ========================================== + Coverage 72.24% 72.65% +0.42% ========================================== Files 14 14 Lines 778 797 +19 ========================================== + Hits 562 579 +17 - Misses 216 218 +2 ``` | [Files Changed](https://app.codecov.io/gh/StanfordSpezi/SpeziOnboarding/pull/23?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi) | Coverage Δ | | |---|---|---| | [...ources/SpeziOnboarding/OnboardingActionsView.swift](https://app.codecov.io/gh/StanfordSpezi/SpeziOnboarding/pull/23?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi#diff-U291cmNlcy9TcGV6aU9uYm9hcmRpbmcvT25ib2FyZGluZ0FjdGlvbnNWaWV3LnN3aWZ0) | `43.11% <ø> (ø)` | | | [...ing/OnboardingFlow/IllegalOnboardingStepView.swift](https://app.codecov.io/gh/StanfordSpezi/SpeziOnboarding/pull/23?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi#diff-U291cmNlcy9TcGV6aU9uYm9hcmRpbmcvT25ib2FyZGluZ0Zsb3cvSWxsZWdhbE9uYm9hcmRpbmdTdGVwVmlldy5zd2lmdA==) | `0.00% <ø> (ø)` | | | [...arding/OnboardingFlow/NavigationPath+Codable.swift](https://app.codecov.io/gh/StanfordSpezi/SpeziOnboarding/pull/23?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi#diff-U291cmNlcy9TcGV6aU9uYm9hcmRpbmcvT25ib2FyZGluZ0Zsb3cvTmF2aWdhdGlvblBhdGgrQ29kYWJsZS5zd2lmdA==) | `94.74% <ø> (ø)` | | | [...ding/OnboardingFlow/OnboardingNavigationPath.swift](https://app.codecov.io/gh/StanfordSpezi/SpeziOnboarding/pull/23?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi#diff-U291cmNlcy9TcGV6aU9uYm9hcmRpbmcvT25ib2FyZGluZ0Zsb3cvT25ib2FyZGluZ05hdmlnYXRpb25QYXRoLnN3aWZ0) | `84.83% <ø> (ø)` | | | [Sources/SpeziOnboarding/ConsentView.swift](https://app.codecov.io/gh/StanfordSpezi/SpeziOnboarding/pull/23?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi#diff-U291cmNlcy9TcGV6aU9uYm9hcmRpbmcvQ29uc2VudFZpZXcuc3dpZnQ=) | `88.47% <50.00%> (ø)` | | | [...ces/SpeziOnboarding/SequentialOnboardingView.swift](https://app.codecov.io/gh/StanfordSpezi/SpeziOnboarding/pull/23?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi#diff-U291cmNlcy9TcGV6aU9uYm9hcmRpbmcvU2VxdWVudGlhbE9uYm9hcmRpbmdWaWV3LnN3aWZ0) | `72.35% <66.67%> (+0.81%)` | :arrow_up: | | [Sources/SpeziOnboarding/SignatureView.swift](https://app.codecov.io/gh/StanfordSpezi/SpeziOnboarding/pull/23?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi#diff-U291cmNlcy9TcGV6aU9uYm9hcmRpbmcvU2lnbmF0dXJlVmlldy5zd2lmdA==) | `91.38% <86.67%> (-2.09%)` | :arrow_down: | | [...eziOnboarding/OnboardingFlow/OnboardingStack.swift](https://app.codecov.io/gh/StanfordSpezi/SpeziOnboarding/pull/23?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi#diff-U291cmNlcy9TcGV6aU9uYm9hcmRpbmcvT25ib2FyZGluZ0Zsb3cvT25ib2FyZGluZ1N0YWNrLnN3aWZ0) | `83.34% <100.00%> (ø)` | | | [...es/SpeziOnboarding/OnboardingInformationView.swift](https://app.codecov.io/gh/StanfordSpezi/SpeziOnboarding/pull/23?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi#diff-U291cmNlcy9TcGV6aU9uYm9hcmRpbmcvT25ib2FyZGluZ0luZm9ybWF0aW9uVmlldy5zd2lmdA==) | `52.06% <100.00%> (+1.36%)` | :arrow_up: | | [Sources/SpeziOnboarding/OnboardingTitleView.swift](https://app.codecov.io/gh/StanfordSpezi/SpeziOnboarding/pull/23?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi#diff-U291cmNlcy9TcGV6aU9uYm9hcmRpbmcvT25ib2FyZGluZ1RpdGxlVmlldy5zd2lmdA==) | `67.65% <100.00%> (+0.99%)` | :arrow_up: | | ... and [1 more](https://app.codecov.io/gh/StanfordSpezi/SpeziOnboarding/pull/23?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi) | | ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/StanfordSpezi/SpeziOnboarding/pull/23?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/StanfordSpezi/SpeziOnboarding/pull/23?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi). Last update [91a61c7...4b8c228](https://app.codecov.io/gh/StanfordSpezi/SpeziOnboarding/pull/23?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi).