search

StanfordSpezi / SpeziOnboarding

Spezi Onboarding module to inform a user or retrieve consent for a study participation
https://swiftpackageindex.com/StanfordSpezi/SpeziOnboarding/documentation/
MIT License
11 stars 5 forks source link

Enforce dark signature ink regardless of the color scheme during consent form export #35

Closed philippzagar closed 5 months ago

philippzagar commented 5 months ago

Enforce dark signature ink regardless of the color scheme during consent form export

:recycle: Current situation & Problem

When exporting the consent form in dark mode, the signature is barely visible because the PKDrawing.image() automatically takes the color scheme into account, converting the ink to white in the dark color scheme. However, as the exported PDF document always has a white background, the signature is barely visible when exporting in dark mode.

:gear: Release Notes

:books: Documentation

Properly documented the reasoning behind change

:white_check_mark: Testing

Tested locally via the UI Test app

:pencil: Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (c0260d2) 77.73% compared to head (de3ad2a) 78.08%.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/StanfordSpezi/SpeziOnboarding/pull/35/graphs/tree.svg?width=650&height=150&src=pr&token=tVwIFVPdJG&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi)](https://app.codecov.io/gh/StanfordSpezi/SpeziOnboarding/pull/35?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi) ```diff @@ Coverage Diff @@ ## main #35 +/- ## ========================================== + Coverage 77.73% 78.08% +0.36% ========================================== Files 21 21 Lines 1001 1017 +16 ========================================== + Hits 778 794 +16 Misses 223 223 ``` | [Files](https://app.codecov.io/gh/StanfordSpezi/SpeziOnboarding/pull/35?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi) | Coverage Δ | | |---|---|---| | [.../SpeziOnboarding/ConsentView/ConsentDocument.swift](https://app.codecov.io/gh/StanfordSpezi/SpeziOnboarding/pull/35?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi#diff-U291cmNlcy9TcGV6aU9uYm9hcmRpbmcvQ29uc2VudFZpZXcvQ29uc2VudERvY3VtZW50LnN3aWZ0) | `88.72% <100.00%> (+1.01%)` | :arrow_up: | ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/StanfordSpezi/SpeziOnboarding/pull/35?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/StanfordSpezi/SpeziOnboarding/pull/35?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi). Last update [c0260d2...de3ad2a](https://app.codecov.io/gh/StanfordSpezi/SpeziOnboarding/pull/35?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi).