Closed philippzagar closed 5 months ago
@PSchmiedmayer Please adjust the merge checks to reflect the debug / release mode testing
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
3ee7135
) 74.63% compared to head (79f17e6
) 77.73%.
Thank you for improving the tests! Is there a specific reason why this was not put right in #35 as this seems to test the functionality there?
@PSchmiedmayer No, not really, just came to my mind after I finished the implementation of https://github.com/StanfordSpezi/SpeziOnboarding/pull/35. Sadly, I cannot really test the ink color of the signature (or at least it's quite hard), so the two things are not directly related (but obviously indirectly related!)
@PSchmiedmayer Please make sure to adjust the merge checks for the Debug / Release builds :) Or do I need to retrigger all actions?
Ok, let's try to keep these things combined PRs if related in the future, looks good for now. I will adjust the build checks 👍
UI Test for consent form export
:recycle: Current situation & Problem
Currently, the consent form export is only tested by storing the PDF via the Standard to the app caches directory. The test only validates that the file actually exists, but doesn't check the content. Also, the functionality of the share sheet is not tested. Also, the package is only building and testing for Debug mode right now.
:gear: Release Notes
:books: Documentation
Proper documentation of the test behavior
:white_check_mark: Testing
This PR only contains a UI test ;)
:pencil: Code of Conduct & Contributing Guidelines
By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines: