StanfordSpezi / SpeziOnboarding

Spezi Onboarding module to inform a user or retrieve consent for a study participation
https://swiftpackageindex.com/StanfordSpezi/SpeziOnboarding/documentation/
MIT License
11 stars 5 forks source link

Add support for visionOS #37

Closed Supereg closed 4 months ago

Supereg commented 4 months ago

Add support for visionOS

:recycle: Current situation & Problem

SpeziOnboarding currently doesn't support visionOS. While the UI isn't tailored towards wide-screen environments it also doesn't compile due to a reliance on UIScreen. This PR adds compatibility for visionOS. We mainly needed to update the Signature View of the OnboardingConsentView to adjust for the larger screen area. The PR added CI setup for the new platform.

:gear: Release Notes

--

:white_check_mark: Testing

Unit test are now running on visionOS and iPadOS.

:pencil: Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

codecov[bot] commented 4 months ago

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (8fb6d9f) 78.08% compared to head (166d4b6) 78.31%.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/StanfordSpezi/SpeziOnboarding/pull/37/graphs/tree.svg?width=650&height=150&src=pr&token=tVwIFVPdJG&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi)](https://app.codecov.io/gh/StanfordSpezi/SpeziOnboarding/pull/37?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi) ```diff @@ Coverage Diff @@ ## main #37 +/- ## ========================================== + Coverage 78.08% 78.31% +0.24% ========================================== Files 21 21 Lines 1017 1028 +11 ========================================== + Hits 794 805 +11 Misses 223 223 ``` | [Files](https://app.codecov.io/gh/StanfordSpezi/SpeziOnboarding/pull/37?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi) | Coverage Δ | | |---|---|---| | [.../SpeziOnboarding/ConsentView/ConsentDocument.swift](https://app.codecov.io/gh/StanfordSpezi/SpeziOnboarding/pull/37?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi#diff-U291cmNlcy9TcGV6aU9uYm9hcmRpbmcvQ29uc2VudFZpZXcvQ29uc2VudERvY3VtZW50LnN3aWZ0) | `89.00% <100.00%> (+0.29%)` | :arrow_up: | | [Sources/SpeziOnboarding/SignatureView.swift](https://app.codecov.io/gh/StanfordSpezi/SpeziOnboarding/pull/37?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi#diff-U291cmNlcy9TcGV6aU9uYm9hcmRpbmcvU2lnbmF0dXJlVmlldy5zd2lmdA==) | `89.14% <100.00%> (+1.33%)` | :arrow_up: | | [...ources/SpeziOnboarding/OnboardingConsentView.swift](https://app.codecov.io/gh/StanfordSpezi/SpeziOnboarding/pull/37?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi#diff-U291cmNlcy9TcGV6aU9uYm9hcmRpbmcvT25ib2FyZGluZ0NvbnNlbnRWaWV3LnN3aWZ0) | `89.43% <92.86%> (+0.11%)` | :arrow_up: | ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/StanfordSpezi/SpeziOnboarding/pull/37?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/StanfordSpezi/SpeziOnboarding/pull/37?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi). Last update [8fb6d9f...166d4b6](https://app.codecov.io/gh/StanfordSpezi/SpeziOnboarding/pull/37?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi).