Open RealLast opened 2 weeks ago
Thank you very much @PSchmiedmayer for the detailed and thoughtful feedback! I went over it carefully and incorporated your suggestions. I have also added a reply to most of your comments, including some considerations.
Regarding the failing test, I saw that we got the following error on iPadOS. "The request was denied by service delegate (SBMainWorkspace) for reason: NotFound ("Application "edu.stanford.spezi.onboarding.testappuitests.xctrunner" is unknown to FrontBoard")"
I am not sure how to solve this, can I do anything on my side to fix this?
Thanks again!
Support for storing multiple consent forms (#50)
:recycle: Current situation & Problem
Closes #50 In the case of multiple
OnboardingConsentView
, it was impossible to distinguish the individual consent forms when storing in theStandard
, as the "store" function of theOnboardingConstraint
only receives aPDFDocument
as a parameter and no additional information.:gear: Release Notes
OnboardingConsentView
andOnboardingConstraint
.ExampleStandard
has been changed to distinguish the two consent forms based on their identifiers "FirstConsentDocument" and "SecondConsentDocument":books: Documentation
*Documented changes in the appropriate Markdown files.
:white_check_mark: Testing
OnboardingConsentView
with an identifier different from the first one.If you accept this PR, there are implications for SpeziTemplateApplication and SpeziStudyApplication, as both use an
OnboardingConsentView
and require to add the "identifier" parameter to the respectiveStandard
. I am happy to make those changes if this PR gets accepted.:pencil: Code of Conduct & Contributing Guidelines
By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines: