StanfordSpezi / SpeziOnboarding

Spezi Onboarding module to inform a user or retrieve consent for a study participation
https://swiftpackageindex.com/StanfordSpezi/SpeziOnboarding/documentation/
MIT License
11 stars 5 forks source link

Supporting to distinguish multiple consent forms during onboarding via an identifier (#50) #51

Open RealLast opened 2 weeks ago

RealLast commented 2 weeks ago

Support for storing multiple consent forms (#50)

:recycle: Current situation & Problem

Closes #50 In the case of multiple OnboardingConsentView, it was impossible to distinguish the individual consent forms when storing in the Standard, as the "store" function of the OnboardingConstraint only receives a PDFDocument as a parameter and no additional information.

:gear: Release Notes

:books: Documentation

*Documented changes in the appropriate Markdown files.

:white_check_mark: Testing

If you accept this PR, there are implications for SpeziTemplateApplication and SpeziStudyApplication, as both use an OnboardingConsentView and require to add the "identifier" parameter to the respective Standard. I am happy to make those changes if this PR gets accepted.

:pencil: Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

RealLast commented 2 days ago

Thank you very much @PSchmiedmayer for the detailed and thoughtful feedback! I went over it carefully and incorporated your suggestions. I have also added a reply to most of your comments, including some considerations.

Regarding the failing test, I saw that we got the following error on iPadOS. "The request was denied by service delegate (SBMainWorkspace) for reason: NotFound ("Application "edu.stanford.spezi.onboarding.testappuitests.xctrunner" is unknown to FrontBoard")"

I am not sure how to solve this, can I do anything on my side to fix this?

Thanks again!