Closed philippzagar closed 1 year ago
Merging #9 (7c9df16) into main (4ca13f2) will increase coverage by
73.98%
. The diff coverage is50.00%
.
@PSchmiedmayer Thanks for the feedback, the branch is now ready to merge, all lints and tests in the pipeline finish successfully. However, some checks are staying on "Wating for status to be reported" (the same also happenes in another repo), even though the actual job (e.g. linting) ran through. Retriggering the CI didn't help. Any hints?
@philippzagar Sorry about that; I need to update the CI requirements as we did some changes under the hood. Will do that and merge the PR in a second 👍
Async action within OnboardingActionsView
:recycle: Current situation & Problem
The
ConsentView
takes an action closure that is synchronous in nature. This closure is passed to theOnboardingActionsView
which also takes an asynchronous function.:bulb: Proposed solution
Enable passing an asynchronous function to the
ConsentView
. This enables the following code block::gear: Release Notes
ConsentView
action parameter takes an asynchronous closure:heavy_plus_sign: Additional Information
--
Related PRs
SpeziTemplateApplication PR
Testing
--
Reviewer Nudging
Very minor code changes
Code of Conduct & Contributing Guidelines
By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines: