StanfordSpezi / SpeziQuestionnaire

Spezi Questionnaire Module
https://swiftpackageindex.com/StanfordSpezi/SpeziQuestionnaire/documentation/
MIT License
6 stars 0 forks source link

Upgrade Spezi to 0.8.0 #18

Closed Supereg closed 11 months ago

Supereg commented 12 months ago

Upgrade Spezi to 0.8.0

:recycle: Current situation & Problem

This PR upgrades to Spezi 0.8.0 and moves to observable.

As discussed, this PR removes the Questionnaire Standard Constraint, as we identified that questionnaire responses typically require local context (e.g., the current selected patient). Therefore, questionnaire completion shall always be handled through the closure.

:gear: Release Notes

:books: Documentation

Documentation was updated and respective parts were removed.

:white_check_mark: Testing

--

:pencil: Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

codecov[bot] commented 12 months ago

Codecov Report

Merging #18 (d65394b) into main (7318923) will decrease coverage by 1.35%. The diff coverage is 75.00%.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/StanfordSpezi/SpeziQuestionnaire/pull/18/graphs/tree.svg?width=650&height=150&src=pr&token=SXbKBp8cEl&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi)](https://app.codecov.io/gh/StanfordSpezi/SpeziQuestionnaire/pull/18?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi) ```diff @@ Coverage Diff @@ ## main #18 +/- ## ========================================== - Coverage 88.38% 87.02% -1.35% ========================================== Files 3 2 -1 Lines 86 77 -9 ========================================== - Hits 76 67 -9 Misses 10 10 ``` | [Files](https://app.codecov.io/gh/StanfordSpezi/SpeziQuestionnaire/pull/18?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi) | Coverage Δ | | |---|---|---| | [Sources/SpeziQuestionnaire/QuestionnaireView.swift](https://app.codecov.io/gh/StanfordSpezi/SpeziQuestionnaire/pull/18?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi#diff-U291cmNlcy9TcGV6aVF1ZXN0aW9ubmFpcmUvUXVlc3Rpb25uYWlyZVZpZXcuc3dpZnQ=) | `85.72% <75.00%> (+4.77%)` | :arrow_up: | | [...ources/SpeziQuestionnaire/ORKOrderedTaskView.swift](https://app.codecov.io/gh/StanfordSpezi/SpeziQuestionnaire/pull/18?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi#diff-U291cmNlcy9TcGV6aVF1ZXN0aW9ubmFpcmUvT1JLT3JkZXJlZFRhc2tWaWV3LnN3aWZ0) | `88.10% <75.00%> (-6.90%)` | :arrow_down: | ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/StanfordSpezi/SpeziQuestionnaire/pull/18?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/StanfordSpezi/SpeziQuestionnaire/pull/18?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi). Last update [7318923...d65394b](https://app.codecov.io/gh/StanfordSpezi/SpeziQuestionnaire/pull/18?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi).
Supereg commented 11 months ago

We have a slightly reduced diff coverage due to the new state handling which is not fully covered by the UI tests (see GitHub review diff). Would it make sense to force merge @PSchmiedmayer?

PSchmiedmayer commented 11 months ago

Sure, merged @Supereg 👍