StanfordSpezi / SpeziQuestionnaire

Spezi Questionnaire Module
https://swiftpackageindex.com/StanfordSpezi/SpeziQuestionnaire/documentation/
MIT License
6 stars 0 forks source link

Replace ORKOrderedTaskView with new ResearchKit one #23

Closed Supereg closed 6 months ago

Supereg commented 6 months ago

Replace ORKOrderedTaskView with new ResearchKit one

:recycle: Current situation & Problem

This PR updates to our latest version of ResearchKit and replaces the internal ORKOrderedTaskView implementation with the new one available in ResearchKitSwiftUI.

:gear: Release Notes

:books: Documentation

--

:white_check_mark: Testing

--

:pencil: Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

codecov[bot] commented 6 months ago

Codecov Report

Attention: Patch coverage is 88.23529% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 85.11%. Comparing base (fac0bb0) to head (2812b70).

:exclamation: Current head 2812b70 differs from pull request most recent head 09c92ac. Consider uploading reports for the commit 09c92ac to get more accurate results

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/StanfordSpezi/SpeziQuestionnaire/pull/23/graphs/tree.svg?width=650&height=150&src=pr&token=SXbKBp8cEl&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi)](https://app.codecov.io/gh/StanfordSpezi/SpeziQuestionnaire/pull/23?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi) ```diff @@ Coverage Diff @@ ## main #23 +/- ## ========================================== - Coverage 87.02% 85.11% -1.90% ========================================== Files 2 1 -1 Lines 77 47 -30 ========================================== - Hits 67 40 -27 + Misses 10 7 -3 ``` | [Files](https://app.codecov.io/gh/StanfordSpezi/SpeziQuestionnaire/pull/23?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi) | Coverage Δ | | |---|---|---| | [Sources/SpeziQuestionnaire/QuestionnaireView.swift](https://app.codecov.io/gh/StanfordSpezi/SpeziQuestionnaire/pull/23?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi#diff-U291cmNlcy9TcGV6aVF1ZXN0aW9ubmFpcmUvUXVlc3Rpb25uYWlyZVZpZXcuc3dpZnQ=) | `85.11% <88.24%> (-0.60%)` | :arrow_down: | ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/StanfordSpezi/SpeziQuestionnaire/pull/23?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/StanfordSpezi/SpeziQuestionnaire/pull/23?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi). Last update [fac0bb0...09c92ac](https://app.codecov.io/gh/StanfordSpezi/SpeziQuestionnaire/pull/23?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi).
Supereg commented 6 months ago

Not sure why codecov doesn't report any updates. Might we just merge?