Closed niallkehoe closed 11 months ago
Nice work @niallkehoe!
@PSchmiedmayer Interesting that this fails the tests on the Github Action but passes all tests on my machine. Any ideas? TestAppUITests.testSchedulerBackgroundNotifications() TestAppUITests.testSchedulerNotifications() TestAppUITests.testSchedulerNotificationsBeforePermissions()
@niallkehoe I have taken a look at the testing issues and it seems like this is related to a runtime crash due to some async overloads of the UNUserNotificationCenterDelegate
protocol.
I could reproduce the crashes in the UI tests using Xcode 15 and using an iOS 17 simulator.
I have moved the code to the completion-based version of the methods in this commit: https://github.com/StanfordSpezi/SpeziScheduler/pull/24/commits/aa271b81bceaf831ab060c8f00b794edb9245f75
Merging #24 (aa271b8) into main (8688e48) will increase coverage by
0.44%
. Report is 1 commits behind head on main. The diff coverage is100.00%
.
New Spezi Standard Implementation
:recycle: Current situation & Problem
Currently, the SpeziScheduler module lacks support for the new Spezi Standard released in Spezi 0.7.0 This PR implements the improvements mentioned in [https://github.com/https://github.com/StanfordSpezi/Spezi/pull/73](Pull 73)
:bulb: Proposed solution
Update the codebase to the newest Spezi 0.7.0
:gear: Release Notes
This feature will allow for greater flexibility when using Spezi Questionnaire.
Related PRs
See [https://github.com/https://github.com/StanfordSpezi/Spezi/pull/73](Pull 73) in Spezi for details
Testing
Passes all tests
Code of Conduct & Contributing Guidelines
By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines: