search

StanfordSpezi / SpeziScheduler

Scheduler Module for the Stanford Spezi Ecosystem
https://swiftpackageindex.com/StanfordSpezi/SpeziScheduler/documentation/
MIT License
3 stars 3 forks source link

Migrate to Observable #33

Closed Supereg closed 7 months ago

Supereg commented 8 months ago

Migrate to Observable

:recycle: Current situation & Problem

This PR migrates SpeziScheduler to use @Observable and upgrades to the latest Spezi dependencies.

:gear: Release Notes

:books: Documentation

Documentation was updated where needed.

:white_check_mark: Testing

Tests were added to ensure we remain compatible with previous Codable representations.

:pencil: Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

codecov[bot] commented 8 months ago

Codecov Report

Merging #33 (13c1824) into main (dcba988) will increase coverage by 0.20%. The diff coverage is 90.37%.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/StanfordSpezi/SpeziScheduler/pull/33/graphs/tree.svg?width=650&height=150&src=pr&token=0VQNE0E1Wp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi)](https://app.codecov.io/gh/StanfordSpezi/SpeziScheduler/pull/33?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi) ```diff @@ Coverage Diff @@ ## main #33 +/- ## ========================================== + Coverage 86.27% 86.46% +0.20% ========================================== Files 5 7 +2 Lines 626 709 +83 ========================================== + Hits 540 613 +73 - Misses 86 96 +10 ``` | [Files](https://app.codecov.io/gh/StanfordSpezi/SpeziScheduler/pull/33?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi) | Coverage Δ | | |---|---|---| | [Sources/SpeziScheduler/Model/Schedule.swift](https://app.codecov.io/gh/StanfordSpezi/SpeziScheduler/pull/33?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi#diff-U291cmNlcy9TcGV6aVNjaGVkdWxlci9Nb2RlbC9TY2hlZHVsZS5zd2lmdA==) | `89.37% <100.00%> (ø)` | | | [Sources/SpeziScheduler/SchedulerStorage.swift](https://app.codecov.io/gh/StanfordSpezi/SpeziScheduler/pull/33?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi#diff-U291cmNlcy9TcGV6aVNjaGVkdWxlci9TY2hlZHVsZXJTdG9yYWdlLnN3aWZ0) | `93.19% <93.19%> (ø)` | | | [Sources/SpeziScheduler/Model/Task.swift](https://app.codecov.io/gh/StanfordSpezi/SpeziScheduler/pull/33?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi#diff-U291cmNlcy9TcGV6aVNjaGVkdWxlci9Nb2RlbC9UYXNrLnN3aWZ0) | `89.81% <94.90%> (ø)` | | | [Sources/SpeziScheduler/Model/TaskList.swift](https://app.codecov.io/gh/StanfordSpezi/SpeziScheduler/pull/33?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi#diff-U291cmNlcy9TcGV6aVNjaGVkdWxlci9Nb2RlbC9UYXNrTGlzdC5zd2lmdA==) | `75.00% <75.00%> (ø)` | | | [Sources/SpeziScheduler/Model/Event.swift](https://app.codecov.io/gh/StanfordSpezi/SpeziScheduler/pull/33?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi#diff-U291cmNlcy9TcGV6aVNjaGVkdWxlci9Nb2RlbC9FdmVudC5zd2lmdA==) | `94.53% <94.53%> (ø)` | | | [Sources/SpeziScheduler/Model/EventState.swift](https://app.codecov.io/gh/StanfordSpezi/SpeziScheduler/pull/33?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi#diff-U291cmNlcy9TcGV6aVNjaGVkdWxlci9Nb2RlbC9FdmVudFN0YXRlLnN3aWZ0) | `50.00% <50.00%> (ø)` | | | [Sources/SpeziScheduler/Scheduler.swift](https://app.codecov.io/gh/StanfordSpezi/SpeziScheduler/pull/33?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi#diff-U291cmNlcy9TcGV6aVNjaGVkdWxlci9TY2hlZHVsZXIuc3dpZnQ=) | `78.54% <85.08%> (-2.88%)` | :arrow_down: | ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/StanfordSpezi/SpeziScheduler/pull/33?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/StanfordSpezi/SpeziScheduler/pull/33?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi). Last update [dcba988...13c1824](https://app.codecov.io/gh/StanfordSpezi/SpeziScheduler/pull/33?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi).
Supereg commented 7 months ago

@PSchmiedmayer as discussed, I removed the timezone handling from the PR as of right now. We will need to revisit this at a later point in time.