search

StanfordSpezi / SpeziScheduler

Scheduler Module for the Stanford Spezi Ecosystem
https://swiftpackageindex.com/StanfordSpezi/SpeziScheduler/documentation/
MIT License
4 stars 3 forks source link

Fix start and end date functionality and add tests #41

Closed AballahNsour closed 4 weeks ago

AballahNsour commented 6 months ago

Name of the PR

:recycle: Current situation & Problem

Link any open issues or pull requests (PRs) related to this PR. Please ensure that all non-trivial PRs are first tracked and discussed in an existing GitHub issue or discussion.

:gear: Release Notes

Add a bullet point list summary of the feature and possible migration guides if this is a breaking change so this section can be added to the release notes. Include code snippets that provide examples of the feature implemented or links to the documentation if it appends or changes the public interface.

:books: Documentation

Please ensure that you properly document any additions in conformance to Spezi Documentation Guide. You can use this section to describe your solution, but we encourage contributors to document your reasoning and changes using in-line documentation.

:white_check_mark: Testing

Please ensure that the PR meets the testing requirements set by CodeCov and that new functionality is appropriately tested. This section describes important information about the tests and why some elements might not be testable.

:pencil: Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

PSchmiedmayer commented 6 months ago

@AballahNsour Thank you for taking a look at the issue! Feel free to create a PR and tag us if you have any questions. Always great to see contributions from outside contributors and we are happy to support you in the process!

AballahNsour commented 6 months ago

forgive me I went though the rules again it happens that i have vaiolated one of contribution rules i Will revert on the changes and I will start over.

PSchmiedmayer commented 6 months ago

No worries; it is always a challenge to get started.

Let us know how we can be helpful, we always appreciate contributions and improvements 🚀

AballahNsour commented 5 months ago

@PSchmiedmayer hello, I did the best i could with adding the two test cases. I may need more assistance, but will learn fast :)

Supereg commented 4 weeks ago

This PR was superseeded by #44