search

StanfordSpezi / SpeziStorage

Spezi module to store information and credentials encrypted at rest
https://swiftpackageindex.com/StanfordSpezi/SpeziStorage/documentation/
MIT License
4 stars 0 forks source link

Fix macOS Keychain support #19

Closed philippzagar closed 7 months ago

philippzagar commented 7 months ago

Fix macOS Keychain support

:recycle: Current situation & Problem

As of now, the LocalStorage and SecureStorage doesn't properly work on macOS as one requires additional keychain settings and entitlements.

:gear: Release Notes

:books: Documentation

Added docs for entitlements and keychain queries

:white_check_mark: Testing

UI tests are passing

:pencil: Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 92.06%. Comparing base (eaed222) to head (43e93b7). Report is 1 commits behind head on main.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/StanfordSpezi/SpeziStorage/pull/19/graphs/tree.svg?width=650&height=150&src=pr&token=q7s8qcnSNy&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi)](https://app.codecov.io/gh/StanfordSpezi/SpeziStorage/pull/19?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi) ```diff @@ Coverage Diff @@ ## main #19 +/- ## ========================================== + Coverage 91.65% 92.06% +0.41% ========================================== Files 6 6 Lines 431 453 +22 ========================================== + Hits 395 417 +22 Misses 36 36 ``` | [Files](https://app.codecov.io/gh/StanfordSpezi/SpeziStorage/pull/19?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi) | Coverage Δ | | |---|---|---| | [Sources/SpeziSecureStorage/SecureStorage.swift](https://app.codecov.io/gh/StanfordSpezi/SpeziStorage/pull/19?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi#diff-U291cmNlcy9TcGV6aVNlY3VyZVN0b3JhZ2UvU2VjdXJlU3RvcmFnZS5zd2lmdA==) | `93.97% <100.00%> (+0.64%)` | :arrow_up: | ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/StanfordSpezi/SpeziStorage/pull/19?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/StanfordSpezi/SpeziStorage/pull/19?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi). Last update [7d1c8ff...43e93b7](https://app.codecov.io/gh/StanfordSpezi/SpeziStorage/pull/19?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi).