Closed Lucas-ZX-W closed 1 year ago
@Lucas-ZX-W, Thank you for your PR and making this improvement!
Can we verify that this issue report/PR is not a duplication of the issue already resolved in https://github.com/StanfordBDHG/CardinalKitTemplateApplication/pull/11?
I can not reproduce that it is possible to interactively dismiss the sheet in the version on the main branch. It seems to me like @vishnuravi solved this issue in the previous PR.
Can you share how we can reproduce that behaviour in the current state on the main branch?
@Lucas-ZX-W Would be great if you can verify that the error still persists after #11 and #12 have been merged into the main project. You might need to update your fork/repo with the latest changes by creating a PR from this main branch to your main branch to get all the latest improvements.
To prevent the user from bypassing the sign-in/account creation process and jumping straight into the “Scheudle” page without an account signed in by dragging the sign-in modal view down and dismissing it.
Disable "pull down to dismiss" for sign-in modal view
:recycle: Current situation & Problem
TemplateOnboardingFlow
uses a ModalView/sheet to display the onboarding/account-sign-in/creation process, the user can swipe down on the modal sheet to dismiss the process anytime during the process and enter the app's main interact without an account sign-ed in (effectively the same as using the launch argument--skipOnboarding
).:bulb: Proposed solution
.interactiveDismissDisabled(true)
to make the Modal View un-dismissible until the intended end of the onboarding flow.Code of Conduct & Contributing Guidelines
By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines: