StanfordSpezi / SpeziTemplateApplication

Template application demonstrating the usage of the Stanford Spezi framework.
https://stanfordspezi.github.io/SpeziTemplateApplication
MIT License
97 stars 19 forks source link

Updated Account Setup and new Account Editing Functionality #35

Closed Supereg closed 11 months ago

Supereg commented 1 year ago

Updated Account Setup and new Account Editing Functionality

:recycle: Current situation & Problem

There is an upcoming release of SpeziAccount that restructures and simplifies account setup procedure. Further, it adds a new Account Overview that allows you to view and edit your active account details.

While it might not be required for all projects, we currently force a user account (e.g. as the standard expects a user account for all operations) even if the user decides to log out.

Furthermore, we restore test case functionality for some tests cases that broke due to the latest accessibility improvements in some dependencies.

For more information see:

:gear: Release Notes

:books: Documentation

In code documentation was adjusted.

:white_check_mark: Testing

Tests were updated to cover new vectors.

:pencil: Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

Supereg commented 1 year ago

~This is currently blocked by https://github.com/StanfordSpezi/SpeziOnboarding/issues/21~

see https://github.com/StanfordSpezi/SpeziAccount/pull/23

codecov[bot] commented 11 months ago

Codecov Report

Merging #35 (0a6b981) into main (d310ca1) will increase coverage by 0.82%. The diff coverage is 92.83%.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/StanfordSpezi/SpeziTemplateApplication/pull/35/graphs/tree.svg?width=650&height=150&src=pr&token=6EPKiz2l15&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi)](https://app.codecov.io/gh/StanfordSpezi/SpeziTemplateApplication/pull/35?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi) ```diff @@ Coverage Diff @@ ## main #35 +/- ## ========================================== + Coverage 80.86% 81.68% +0.82% ========================================== Files 30 32 +2 Lines 815 846 +31 ========================================== + Hits 659 691 +32 + Misses 156 155 -1 ``` | [Files Changed](https://app.codecov.io/gh/StanfordSpezi/SpeziTemplateApplication/pull/35?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi) | Coverage Δ | | |---|---|---| | [...n/Onboarding/OnboardingFlow+PreviewSimulator.swift](https://app.codecov.io/gh/StanfordSpezi/SpeziTemplateApplication/pull/35?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi#diff-VGVtcGxhdGVBcHBsaWNhdGlvbi9PbmJvYXJkaW5nL09uYm9hcmRpbmdGbG93K1ByZXZpZXdTaW11bGF0b3Iuc3dpZnQ=) | `0.00% <0.00%> (ø)` | | | [...tion/Schedule/TemplateApplicationTaskContext.swift](https://app.codecov.io/gh/StanfordSpezi/SpeziTemplateApplication/pull/35?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi#diff-VGVtcGxhdGVBcHBsaWNhdGlvbi9TY2hlZHVsZS9UZW1wbGF0ZUFwcGxpY2F0aW9uVGFza0NvbnRleHQuc3dpZnQ=) | `43.75% <66.67%> (ø)` | | | [TemplateApplication/Account/AccountSheet.swift](https://app.codecov.io/gh/StanfordSpezi/SpeziTemplateApplication/pull/35?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi#diff-VGVtcGxhdGVBcHBsaWNhdGlvbi9BY2NvdW50L0FjY291bnRTaGVldC5zd2lmdA==) | `78.95% <78.95%> (ø)` | | | [...plateApplication/TemplateApplicationStandard.swift](https://app.codecov.io/gh/StanfordSpezi/SpeziTemplateApplication/pull/35?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi#diff-VGVtcGxhdGVBcHBsaWNhdGlvbi9UZW1wbGF0ZUFwcGxpY2F0aW9uU3RhbmRhcmQuc3dpZnQ=) | `37.65% <85.00%> (+3.92%)` | :arrow_up: | | [TemplateApplication/MockUpload/MockUpload.swift](https://app.codecov.io/gh/StanfordSpezi/SpeziTemplateApplication/pull/35?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi#diff-VGVtcGxhdGVBcHBsaWNhdGlvbi9Nb2NrVXBsb2FkL01vY2tVcGxvYWQuc3dpZnQ=) | `92.31% <87.50%> (-7.69%)` | :arrow_down: | | [...emplateApplication/Schedule/EventContextView.swift](https://app.codecov.io/gh/StanfordSpezi/SpeziTemplateApplication/pull/35?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi#diff-VGVtcGxhdGVBcHBsaWNhdGlvbi9TY2hlZHVsZS9FdmVudENvbnRleHRWaWV3LnN3aWZ0) | `90.91% <87.50%> (-1.19%)` | :arrow_down: | | [TemplateApplication/Schedule/ScheduleView.swift](https://app.codecov.io/gh/StanfordSpezi/SpeziTemplateApplication/pull/35?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi#diff-VGVtcGxhdGVBcHBsaWNhdGlvbi9TY2hlZHVsZS9TY2hlZHVsZVZpZXcuc3dpZnQ=) | `86.91% <88.89%> (+1.38%)` | :arrow_up: | | [...eApplication/Account/AccountRequiredModifier.swift](https://app.codecov.io/gh/StanfordSpezi/SpeziTemplateApplication/pull/35?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi#diff-VGVtcGxhdGVBcHBsaWNhdGlvbi9BY2NvdW50L0FjY291bnRSZXF1aXJlZE1vZGlmaWVyLnN3aWZ0) | `96.16% <96.16%> (ø)` | | | [TemplateApplication/Account/AccountButton.swift](https://app.codecov.io/gh/StanfordSpezi/SpeziTemplateApplication/pull/35?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi#diff-VGVtcGxhdGVBcHBsaWNhdGlvbi9BY2NvdW50L0FjY291bnRCdXR0b24uc3dpZnQ=) | `100.00% <100.00%> (ø)` | | | [...mplateApplication/Account/AccountRequiredKey.swift](https://app.codecov.io/gh/StanfordSpezi/SpeziTemplateApplication/pull/35?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi#diff-VGVtcGxhdGVBcHBsaWNhdGlvbi9BY2NvdW50L0FjY291bnRSZXF1aXJlZEtleS5zd2lmdA==) | `100.00% <100.00%> (ø)` | | | ... and [12 more](https://app.codecov.io/gh/StanfordSpezi/SpeziTemplateApplication/pull/35?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi) | | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/StanfordSpezi/SpeziTemplateApplication/pull/35/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/StanfordSpezi/SpeziTemplateApplication/pull/35?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/StanfordSpezi/SpeziTemplateApplication/pull/35?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi). Last update [d310ca1...0a6b981](https://app.codecov.io/gh/StanfordSpezi/SpeziTemplateApplication/pull/35?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi).
Supereg commented 11 months ago

We still want to incorporate https://github.com/StanfordSpezi/SpeziAccount/pull/24

EDIT: ✅