Closed NikolaiMadlener closed 10 months ago
Just a first shot for my interpretation of #29.
Hi @NikolaiMadlener great to see you here! Let us know once you deem the PR ready for review and tag me if you have any questions! 👍
@PSchmiedmayer from my side this one is ready for review 🙂
Thank you @NikolaiMadlener! I will take a look at the PR later this week.
I have also approved it to run on our build infrastructure. It would be great if you can inspect the output of the builds and the resulting test coverage and see if you can add a small UI test to test that the rough functionality is working. No need to check all the dependencies in the UI itself. Please also take a look at the failing SwiftLint rule.
Regarding the build error: I suspect that we need to add the flag described here in our Fastlane Xcodebuild setup to ensure that the package can be run in the CI environment: https://forums.swift.org/t/telling-xcode-14-beta-4-to-trust-build-tool-plugins-programatically/59305
@NikolaiMadlener Nice stuff, love the dynamic fetching of packages via the PackageHelper
! 🚀
Merging #36 (c9b93db) into main (5f4e95c) will increase coverage by
0.71%
. The diff coverage is86.21%
.
Thanks for the great first feedback @PSchmiedmayer ! Will adopt all of the points. Exactly, ZStack will be removed once my PR with the addition to SpeziAccount is merged.
Sounds great; thank you @NikolaiMadlener 👍
@NikolaiMadlener Thank you for the great improvements and additions to the template application! I really like to approach using
SwiftPackageList
, which is a very smooth integration in the build pipeline.Also, it's great to see the addition to SpeziAccount that will then embed this information in the Account overview; this should then replace the
ZStack
that you have in place here.Before doing a more detailed review when these elements are in place, I can already suggest the following:
- The current implementation is based on a lot of the foundational work of the
SwiftPackageList
package and the views and examples from this package. I would suggest that you clearly highlight the code that you have reused from the project in the license identifier and properly provide attribution. Also, make sure that you are allowed to reuse the code here according to the license of the package.- The current implementation does not use the Xcode/Swift localization mechanism. I have recently improved the setup in Use String Catalogues & Update to the Latest Spezi Packages #39, and this might directly benefit this PR. I would suggest that we localize all the values here as well.
- I would suggest merging the latest version of the main branch into your fork + feature branch to ensure that the latest version of the CI is used and that you can automatically check the builds in this PR.
- It would be great if we could support all the different license types that we currently have in our dependencies to complete the view.
And not sure if this is a misinterpretation, bit the version numbers seem to be slightly indented compared to the name:
@PSchmiedmayer Your initial feedback should be implemented now.
Regarding 1., SwiftPackageList
is licensed under MIT so the usage should be fine. I also attributed the code that is based on the work of the SwiftPackageList
repo (as a comment within the Package+LicenseType.swift
).
Please let me know if there is anything else I can improve before this can be merged.
Add an Open-Source Contributions Screen
:recycle: Current situation & Problem
The application currently does not provide any way to see all open-source tools used within the app, nor does it give access to all licenses used. See: https://github.com/StanfordSpezi/SpeziTemplateApplication/issues/29
:gear: Release Notes
Here is how it looks like:
![Simulator Screenshot - iPhone 14 Pro - 2023-09-18 at 15 43 13](https://github.com/StanfordSpezi/SpeziTemplateApplication/assets/33159293/21918fcb-2646-4107-a04d-44ead92ced72)
:books: Documentation
TBA
:white_check_mark: Testing
:pencil: Code of Conduct & Contributing Guidelines
By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines: