StanfordSpezi / SpeziTemplateApplication

Template application demonstrating the usage of the Stanford Spezi framework.
https://stanfordspezi.github.io/SpeziTemplateApplication
MIT License
97 stars 19 forks source link

Fix issues writing to Firestore #46

Closed Supereg closed 10 months ago

Supereg commented 10 months ago

Fix firestore rules

:recycle: Current situation & Problem

The firestore rules were ill-formatted and therefore all write to the firestore simulator were rejected. This PR fixes this problem by updating the firestore.rules configuration to include the version information and fixing syntax issues.

:gear: Release Notes

:books: Documentation

--

:white_check_mark: Testing

--

:pencil: Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

codecov[bot] commented 10 months ago

Codecov Report

Merging #46 (08726e3) into main (5796d90) will decrease coverage by 0.20%. The diff coverage is n/a.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/StanfordSpezi/SpeziTemplateApplication/pull/46/graphs/tree.svg?width=650&height=150&src=pr&token=6EPKiz2l15&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi)](https://app.codecov.io/gh/StanfordSpezi/SpeziTemplateApplication/pull/46?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi) ```diff @@ Coverage Diff @@ ## main #46 +/- ## ========================================== - Coverage 81.80% 81.60% -0.20% ========================================== Files 35 35 Lines 978 978 ========================================== - Hits 800 798 -2 - Misses 178 180 +2 ``` [see 1 file with indirect coverage changes](https://app.codecov.io/gh/StanfordSpezi/SpeziTemplateApplication/pull/46/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/StanfordSpezi/SpeziTemplateApplication/pull/46?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/StanfordSpezi/SpeziTemplateApplication/pull/46?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi). Last update [5796d90...08726e3](https://app.codecov.io/gh/StanfordSpezi/SpeziTemplateApplication/pull/46?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi).
PSchmiedmayer commented 10 months ago

Thank you @Supereg!