StanfordSpezi / SpeziTemplateApplication

Template application demonstrating the usage of the Stanford Spezi framework.
https://stanfordspezi.github.io/SpeziTemplateApplication
MIT License
97 stars 19 forks source link

Fix UI updates for the ScheduleView #73

Closed Supereg closed 5 months ago

Supereg commented 5 months ago

Fix UI updates for the ScheduleView

:recycle: Current situation & Problem

Currently, the schedule view is re-rendered based on equatable conformance and on first appearance. This is not ideal, as the task modifier is only executed once on appearance (which is not the equivalent to the ScenePhase). This restructures the schedule view to make sure all changes are observed.

:gear: Release Notes

:pencil: Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 80.52%. Comparing base (97635ac) to head (75db0a7).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/StanfordSpezi/SpeziTemplateApplication/pull/73/graphs/tree.svg?width=650&height=150&src=pr&token=6EPKiz2l15&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi)](https://app.codecov.io/gh/StanfordSpezi/SpeziTemplateApplication/pull/73?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi) ```diff @@ Coverage Diff @@ ## main #73 +/- ## ========================================== - Coverage 80.54% 80.52% -0.01% ========================================== Files 31 31 Lines 976 965 -11 ========================================== - Hits 786 777 -9 + Misses 190 188 -2 ``` | [Files](https://app.codecov.io/gh/StanfordSpezi/SpeziTemplateApplication/pull/73?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi) | Coverage Δ | | |---|---|---| | [TemplateApplication/Schedule/ScheduleView.swift](https://app.codecov.io/gh/StanfordSpezi/SpeziTemplateApplication/pull/73?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi#diff-VGVtcGxhdGVBcHBsaWNhdGlvbi9TY2hlZHVsZS9TY2hlZHVsZVZpZXcuc3dpZnQ=) | `83.79% <100.00%> (+0.26%)` | :arrow_up: | ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/StanfordSpezi/SpeziTemplateApplication/pull/73?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/StanfordSpezi/SpeziTemplateApplication/pull/73?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi). Last update [97635ac...75db0a7](https://app.codecov.io/gh/StanfordSpezi/SpeziTemplateApplication/pull/73?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi).