StanfordSpezi / SpeziTemplateApplication

Template application demonstrating the usage of the Stanford Spezi framework.

https://stanfordspezi.github.io/SpeziTemplateApplication

MIT License

97 stars 19 forks source link

Simplify and cleanup template app #81

Closed Supereg closed 2 months ago

Supereg commented 2 months ago

Simplify and cleanup template app

:recycle: Current situation & Problem

This PR tries to do some housekeeping for the template app. Refer to the release notes for a list of changes.

:gear: Release Notes

Updated dependencies.
Removed Codable-based RawRepresentable conformance for array to avoid anti-patterns with @AppStorage.
Automatically pass PreferLogStreaming=YES to the environment to silence warning.
Remove setupSimulators, saving some seconds in the CI.
Remove MockWebService.

:books: Documentation

Removed some outdated screenshots related to the MockWebService integration.

:white_check_mark: Testing

Removed outdated tests.

:pencil: Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

[x] I agree to follow the Code of Conduct and Contributing Guidelines.

Supereg commented 2 months ago

I adjusted some of the timeout values in the Fastfile as they were continuously hit by the build jobs. Specifically for CodeQL this should save like 5 minutes (which isn't a lot for the whopping 30-40 minutes build time). Do you think it is possible to offload compilation to our custom runners (e.g., upload derived data as a build artifact and just download it for the CodeQL job). Or does the CodeQL swift extractor inject itself into the build process? Can't quite find any good resources for how exactly the swift support is achieved.