StanfordSpezi / SpeziViews

A common set of SwiftUI views and related functionality used in Spezi modules
https://swiftpackageindex.com/StanfordSpezi/SpeziViews/documentation/
MIT License
4 stars 3 forks source link

View State Enhancements #19

Closed philippzagar closed 12 months ago

philippzagar commented 1 year ago

View State Enhancements

:recycle: Current situation & Problem

At the moment, ViewStates are designed to be used throughout the SpeziViews architecture, however, the actual utilization of those ViewStates is quite limited. This is especially true for MarkdownView and HTMLView views, as they have the architecture to handle ViewStates, but they aren't used for now (see StanfordSpezi/SpeziOnboarding#26).

:gear: Release Notes

:books: Documentation

--

:white_check_mark: Testing

Test cases have been adjusted.

:pencil: Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

philippzagar commented 12 months ago

@PSchmiedmayer Incorporated your feedback (thanks!). Keep in mind that I also switched the XCTestExtensions dependency to the StanfordBDHG orga. Will merge as soon as the pipeline succeeds.

philippzagar commented 12 months ago

@PSchmiedmayer Seems like the UI Tests are quite flakey in the pipeline, pushed some improvements now.

codecov[bot] commented 12 months ago

Codecov Report

Merging #19 (257494f) into main (8e25d88) will decrease coverage by 1.27%. The diff coverage is 61.67%.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/StanfordSpezi/SpeziViews/pull/19/graphs/tree.svg?width=650&height=150&src=pr&token=7UbLX71dAO&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi)](https://app.codecov.io/gh/StanfordSpezi/SpeziViews/pull/19?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi) ```diff @@ Coverage Diff @@ ## main #19 +/- ## ========================================== - Coverage 76.75% 75.47% -1.27% ========================================== Files 23 23 Lines 817 856 +39 ========================================== + Hits 627 646 +19 - Misses 190 210 +20 ``` | [Files](https://app.codecov.io/gh/StanfordSpezi/SpeziViews/pull/19?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi) | Coverage Δ | | |---|---|---| | [Sources/SpeziViews/Views/Text/DocumentView.swift](https://app.codecov.io/gh/StanfordSpezi/SpeziViews/pull/19?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi#diff-U291cmNlcy9TcGV6aVZpZXdzL1ZpZXdzL1RleHQvRG9jdW1lbnRWaWV3LnN3aWZ0) | `69.57% <100.00%> (ø)` | | | [Sources/SpeziViews/Views/Text/HTMLView.swift](https://app.codecov.io/gh/StanfordSpezi/SpeziViews/pull/19?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi#diff-U291cmNlcy9TcGV6aVZpZXdzL1ZpZXdzL1RleHQvSFRNTFZpZXcuc3dpZnQ=) | `82.26% <62.97%> (-15.03%)` | :arrow_down: | | [Sources/SpeziViews/Views/Text/MarkdownView.swift](https://app.codecov.io/gh/StanfordSpezi/SpeziViews/pull/19?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi#diff-U291cmNlcy9TcGV6aVZpZXdzL1ZpZXdzL1RleHQvTWFya2Rvd25WaWV3LnN3aWZ0) | `69.82% <58.07%> (-14.80%)` | :arrow_down: | ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/StanfordSpezi/SpeziViews/pull/19?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/StanfordSpezi/SpeziViews/pull/19?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi). Last update [8e25d88...257494f](https://app.codecov.io/gh/StanfordSpezi/SpeziViews/pull/19?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=StanfordSpezi).
philippzagar commented 12 months ago

@PSchmiedmayer Please merge ;)