Closed Supereg closed 2 months ago
@PSchmiedmayer the Snapshots test are failing within the CI. If you look at the xcresult bundle, the snapshot images don't differ though. I couldn't reproduce the failure locally. I also tried to regenerate the images (they resulted in the exact same binary representation).
@Supereg As noted on Slack: I unfortunately don't have a clear idea where this might come from, let me know if you want me to dig deeper into this!
@Supereg As noted on Slack: I unfortunately don't have a clear idea where this might come from, let me know if you want me to dig deeper into this!
Maybe we can wait for Xcode 16 beta 4 release today and see if that changes anything? Otherwise, let's discuss other strategies in the meeting later.
@Supereg I have just installed the Xcode 16 Beta 4 on all macOS runners that we host.
@Supereg I have just installed the Xcode 16 Beta 4 on all macOS runners that we host.
Just resolved the issue. It seems there is a difference, if the snapshot tests are run on the iOS 18 simulator vs on an iOS 17.5 simulator. The iOS 18 simulator slightly changes shadows around text which made all of the snapshot testing fail. This is now resolved.
I added some additional minor changes to the PR, like improving Sendable annotation of ValidationRule
, allow arbitrarily built Regex instances with ValidationRule and slightly improving flexibility of the VerifiableTextField
. I re-requested a review to cover those changes π
Attention: Patch coverage is 93.75000%
with 1 line
in your changes missing coverage. Please review.
Project coverage is 80.45%. Comparing base (
ff61e65
) to head (7d92cad
).
Files | Patch % | Lines |
---|---|---|
Sources/SpeziValidation/ValidationRule.swift | 88.89% | 1 Missing :warning: |
Minor Strict Concurrency fix
:recycle: Current situation & Problem
This PR adds a missing Sendable conformance.
:gear: Release Notes
ValidationEngine
in the environment withVerifiableTextField
for greater flexibility.:books: Documentation
--
:white_check_mark: Testing
--
:pencil: Code of Conduct & Contributing Guidelines
By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines: