StanfordVL / OmniGibson

OmniGibson: a platform for accelerating Embodied AI research built upon NVIDIA's Omniverse engine. Join our Discord for support: https://discord.gg/bccR5vGFEx
https://behavior.stanford.edu/omnigibson/
MIT License
461 stars 50 forks source link

NumPy -> Torch #780

Closed hang-yin closed 1 month ago

hang-yin commented 3 months ago

High level changes:

TODO:

ChengshuLi commented 2 months ago

Really great work Hang! A couple high-level comments:

  1. You mentioned a performence regression due to synchronization. Is that resolved?
  2. For each of the issues I mentioned above, you should consider doing a global search, because I am not being exhaustive for every occurrence of these issues.
  3. Can we make sure all the tests / examples as tests pass before merging this PR? What's the current status?
  4. Currently I rubberstamped the transform_utils.py because I am not sure whether the math is completely correct. Any suggestoin for how I should actually review this?