Fix segfault-failing tests not getting picked up as failing checks in report

StanfordVL / OmniGibson

OmniGibson: a platform for accelerating Embodied AI research built upon NVIDIA's Omniverse engine. Join our Discord for support: https://discord.gg/bccR5vGFEx

https://behavior.stanford.edu/omnigibson/

MIT License

459 stars 48 forks source link

Fix segfault-failing tests not getting picked up as failing checks in report #912

Open cgokmen opened 3 hours ago

cgokmen commented 3 hours ago

Currently, if a test fails with a segfault etc. that prevents the writing of the report, this line doesnt catch it:

https://github.com/StanfordVL/OmniGibson/blob/be687a42defff4ae08bec22de6bcaa9ed146631f/.github/workflows/tests.yml#L73

And there's nothing preventing the report from succeeding when certain tests DONT have outputs.

So if our tests fail hard enough they just disappear from the list of tests :(

cgokmen commented 3 hours ago

FYI @ChengshuLi @cremebrule