StanfordVLSI / dragonphy2

Open Source PHY v2
Apache License 2.0
22 stars 2 forks source link

Analog core5 #96

Closed sjkim85 closed 4 years ago

sjkim85 commented 4 years ago

V2T_clock_gen.sv is modified to fix the en_sync sequence issue. Now, data sequence at adc output looks good but it still looks wired after dcore. I want @standanley to look at this

sjkim85 commented 4 years ago

@standanley , Can merge this to master?

sjkim85 commented 4 years ago

@standanley , Can you merge this to master?

standanley commented 4 years ago

I just added a commit to change the en_sync chain so the signals should be in order. I am surprised to see that the AC test was passing because it looks like somebody already got rid of the magic re-ordering with the old en_sync chain. Was there a different change made that affected the ordering of ADC clocks?

sjkim85 commented 4 years ago

@standanley I've changed the index ordering back to normal in order to test the fixed version in this PR. That's the only change I have made in testbench

codecov-io commented 4 years ago

Codecov Report

Merging #96 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #96   +/-   ##
=======================================
  Coverage   22.26%   22.26%           
=======================================
  Files          33       33           
  Lines        1909     1909           
=======================================
  Hits          425      425           
  Misses       1484     1484           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4a45008...5914ceb. Read the comment docs.

standanley commented 4 years ago

I made a change to the default values for the config register codes for the retimer. I think before there was a problem with different ADCs having different latency. For me, this fixes issues with top_i.idcore.adcout_retimed when I look at the waveforms.

It does not affect the AC test because that pulls data from before the retimer.

sjkim85 commented 4 years ago

Thanks for your work. As you know, we have to run AC test with final output of dcore (input to SRAM) eventually.

zamyers commented 4 years ago

LGTM