Potential improvement, drop classNames dependency

Stanko / react-animate-height

Lightweight React component for animating height using CSS transitions. Slide up/down the element, and animate it to any specific height.

https://muffinman.io/react-animate-height

MIT License

758 stars 53 forks source link

Potential improvement, drop classNames dependency #135

Closed EarthlingDavey closed 1 year ago

EarthlingDavey commented 1 year ago

Hi I think there's a potential here to drop the classNames dependency.

Here I've replaced it with:

add classes to an array (some will be false if conditions aren't met)
filter for truthy values
join array elements with a space

I 100% don't mind if you don't merge. I have done this work anyway for my own project.

Cheers, Davey

Stanko commented 1 year ago

Hi @EarthlingDavey, Thank you for the contribution! ATM I have some personal stuff to take care of, but I will probably merge this in the next 7-10 days. I'm always interested in dropping dependencies 🙈

Cheers!

EarthlingDavey commented 1 year ago

Awesome, and thanks for the project BTW. I just dropped it into my app and it works 100% - will reccomend :)

Stanko commented 1 year ago

Thanks again, released in 3.1.0 🎉

EarthlingDavey commented 1 year ago

No problem bud 🎉✌️