search

Stanko / react-animate-height

Lightweight React component for animating height using CSS transitions. Slide up/down the element, and animate it to any specific height.
https://muffinman.io/react-animate-height
MIT License
758 stars 53 forks source link

animateOpacity missing from index.d.ts #58

Closed jakoandersen closed 6 years ago

jakoandersen commented 6 years ago

This causes TypeScript to complain when compiling. Adding the property to index.d.ts fixes it.

Stanko commented 6 years ago

Hello @jakoandersen, Can you please make a PR or at least provide me with the code snippet? I'm not really using ts. Cheers!

EDIT: Any other properties missing?

jakoandersen commented 6 years ago

Hello @Stanko

Simply adding the following to AnimateHeightProps interface:

animateOpacity?: boolean;

Fixes the issue. I didn't try out the other props.

EDIT: No, that's the only prop missing 😄

Stanko commented 6 years ago

Fixed in v2.0.2. Thanks for checking!

jakoandersen commented 6 years ago

Can you publish v2.0.2 to npm as well?

Stanko commented 6 years ago

I already did 🎉 https://www.npmjs.com/package/react-animate-height/v/2.0.2

jakoandersen commented 6 years ago

Cool, thanks. I was seeing cached results.