search

Stanko / react-animate-height

Lightweight React component for animating height using CSS transitions. Slide up/down the element, and animate it to any specific height.
https://muffinman.io/react-animate-height
MIT License
758 stars 53 forks source link

Adding opacity delay #77

Closed cereallarceny closed 5 years ago

cereallarceny commented 5 years ago

I added a separate delay to opacity because it looks cool to be able to stagger them. Feel free to merge it or dismiss the entire PR. I wanted this for my own purposes and figured it would be helpful to create a PR if anyone else wants this functionality. :)

Stanko commented 5 years ago

Hi @cereallarceny, I'm willing to accept PRs like yours, but it seems that your editor didn't respect eslint configuration used by this project. It resulted in over 500 lines changed. If you can, please revert these changes, and then I can review it.

Also I would be grateful if you can create a live example on https://codesandbox.io/ or similar tool.

Best, Stanko

cereallarceny commented 5 years ago

No worries @Stanko! It turns out I had Prettier turned on, so it replaced a lot of your code with my defaults. I'll turn it off for this.

Either way, your package-lock.json appears to be corrupted. I couldn't do an NPM install without completely deleting it and rebuilding. I'll try to avoid committing this file on my next PR, but it's necessary for me locally.

Stanko commented 5 years ago

I think package lock is for node v9 if I remember correctly. Thank you!