Stanley008 / Symbolic_Computation_2019

ICA2
Eclipse Public License 2.0
2 stars 0 forks source link

Solving issues that appeared after merging #29 #30

Closed Tocrak closed 4 years ago

Tocrak commented 4 years ago

After merging #29 several issues appeared.

  1. The reset_questions function should be moved in the main_loop function in order to reset the correct questions. Also a new parameter should be given to this function (question_obj_vector).
  2. The approve_ending? function still uses the Answers from the park topic and because they are now situated in park_data.clj it will crash the chatbot. To solve this, a function (give_answer) should be created for each topic to give the answer with the correct sentences for the given topic.
  3. In main_loop while assigning question_obj because it assigns itself the data/question_objects which no longer exists. In order to solve this issue, the assigned variable should be (rand-nth question_obj_vector).
  4. The find_topic function do not behave correctly, because it searches if a word is contained inside a vector instead of a set. Solved by adding (set ') in front of the vector of words.
  5. The reset_questions function crashes and doesn't reset the question objects when the user agrees to continue the conversation or when the user enters a word to quit the chatbot in the middle of the conversation. Solved by adding question_obj_vector parameter in approved_ending? functions.

To do: