soc-pe-bot
commented
1 year ago Team's Response
The behaviour experienced is the intended behaviour. In the User Guide, a warning was given that this behaviour would occur if the user were to edit the JSON file iin a way that results in an incorrect format.
Items for the Tester to Verify
:question: Issue response
Team chose [response.Rejected]
- [x] I disagree
Reason for disagreement: It is true that the user guide has given a warning that this behaviour would occur. However, it will still be greatly beneficial to the user experience to display a warning or some kind of indication on application launch when the storage has been corrupted and become unreadable. Hence, this issue is not completely invalid.
Had the Appendix: Planned Enhancement describe a more graceful way of indicating that the storage has been corrupted to the user, this issue would be invalid and I would have agreed with it being rejected.
However, as the Appendix: Planned Enhancement did not detail a possible solution, I believe that OutOfScope would be a more appropriate response to the issue compared to Rejected
Modifying the data in the application as shown below, causes the application to boot up with no data.
This is likely an error being thrown while loading the data up to storage and the decision was made to start with an empty application if there was such an error. However, it will be good if there was an error or warning thrown instead about a possible corruption in data.
How to replicate: Modify the data in the addressbook.json file to an invalid state
Expected outcome: A warning is thrown by the application that the json file is unreadable or has been corrupted, prompting the user to rectify.
Actual outcome: Application starts up normally with no data and no warnings.