search

Stanzilla / AdvancedInterfaceOptions

WoW Addon that restores access to removed interface options in Legion
https://www.curseforge.com/wow/addons/advancedinterfaceoptions
48 stars 13 forks source link

fix Lag Tolerance option #6

Closed Ketho closed 8 years ago

Ketho commented 8 years ago

This should fix the Lag Tolerance option not saving as reported by comment #247 and make it look more similar to the original Blizzard options http://imgur.com/a/uUA1u

Not sure what the difference is between Get/SetChecked and Get/SetValue in the OnShow script though https://github.com/Stanzilla/AdvancedInterfaceOptions/pull/6/files#diff-649a225e94c89f4225e1cebfa6f919e3R491

I don't know if the reducedLagTolerance cvar is supposed to do anything other than toggling the visibility of the spellStartRecovery slider

(Edit) also removed the renamed Sound_EnableSoftwareHRTF cvar

semlar commented 8 years ago

Just change both reducedLagTolerance:SetScript lines to reducedLagTolerance:HookScript, instead of adding self:SetValue and self:SetChecked.

The SetScripts are overwriting the default scripts so it isn't saving the cvar properly.

Stanzilla commented 8 years ago

Thanks!