Stanzilla / WoWUIBugs

World of Warcraft UI Bug Tracker
167 stars 7 forks source link

CONFIRM_OVERWRITE_TRANSMOG_OUTFIT dialog calls missing SaveOutfit method #174

Closed Meorawr closed 3 years ago

Meorawr commented 3 years ago

The CONFIRM_OVERWRITE_TRANSMOG_OUTFIT static popup dialog calls WardrobeOutfitFrame:SaveOutfit in its OnAccept handler, which is a method that doesn't exist.

To reproduce the issue, at a transmogrification NPC create a new outfit with the name "Test", and then create a second outfit with the same name. When prompted if you want to overwrite it, click "Yes".

1x FrameXML\StaticPopup.lua:3845: attempt to call method 'SaveOutfit' (a nil value)
[string "@FrameXML\StaticPopup.lua"]:3845: in function `OnAccept'
[string "@FrameXML\StaticPopup.lua"]:5089: in function `StaticPopup_OnClick'
[string "*:OnClick"]:1: in function <[string "*:OnClick"]:1>

Locals:
self = StaticPopup1 {
 0 = <userdata>
 hideOnEscape = 1
 CoverFrame = <unnamed> {
 }
 itemFrame = StaticPopup1ItemFrame {
 }
 Border = <unnamed> {
 }
 button3 = StaticPopup1Button3 {
 }
 extraFrame = StaticPopup1ExtraFrame {
 }
 data = "wew"
 icon = StaticPopup1AlertIcon {
 }
 maxWidthSoFar = 320
 button2 = StaticPopup1Button2 {
 }
 moneyFrame = StaticPopup1MoneyFrame {
 }
 moneyInputFrame = StaticPopup1MoneyInputFrame {
 }
 SubText = <unnamed> {
 }
 text = StaticPopup1Text {
 }
 ItemFrame = StaticPopup1ItemFrame {
 }
 editBox = StaticPopup1EditBox {
 }
 timeleft = 0
 numButtons = 2
 extraButton = StaticPopup1ExtraButton {
 }
 Separator = <unnamed> {
 }
 button4 = StaticPopup1Button4 {
 }
 maxHeightSoFar = 84.999960
 button1 = StaticPopup1Button1 {
 }
 which = "CONFIRM_OVERWRITE_TRANSMOG_OUTFIT"
}
(*temporary) = nil
(*temporary) = WardrobeOutfitFrame {
 0 = <userdata>
 StartHideCountDown = <function> defined @FrameXML\WardrobeOutfits.lua:235
 Update = <function> defined @FrameXML\WardrobeOutfits.lua:243
 StopHideCountDown = <function> defined @FrameXML\WardrobeOutfits.lua:239
 NameOutfit = <function> defined @FrameXML\WardrobeOutfits.lua:326
 hasInvalidAppearances = false
 Toggle = <function> defined @FrameXML\WardrobeOutfits.lua:196
 popupDropDown = WardrobeOutfitDropDown {
 }
 OnUpdate = <function> defined @FrameXML\WardrobeOutfits.lua:208
 DeleteOutfit = <function> defined @FrameXML\WardrobeOutfits.lua:322
 hasValidAppearances = true
 itemTransmogInfoList = <table> {
 }
 Buttons = <table> {
 }
 OnHide = <function> defined @FrameXML\WardrobeOutfits.lua:192
 pendingAppearances = <table> {
 }
 ClosePopups = <function> defined @FrameXML\WardrobeOutfits.lua:365
 popups = <table> {
 }
 dropDown = WardrobeOutfitDropDown {
 }
 Border = <unnamed> {
 }
 EvaluateSaveState = <function> defined @FrameXML\WardrobeOutfits.lua:383
 SaveLastOutfit = <function> defined @FrameXML\WardrobeOutfits.lua:410
 ContinueWithSave = <function> defined @FrameXML\WardrobeOutfits.lua:400
 ShowPopup = <function> defined @FrameXML\WardrobeOutfits.lua:346
 NewOutfit = <function> defined @FrameXML\WardrobeOutfits.lua:299
}
(*temporary) = "wew"
(*temporary) = "attempt to call method 'SaveOutfit' (a nil value)"
Meorawr commented 3 years ago

Fixed in 9.1.5.40496.