9.1: Event Log ScrollBoxList issues

[Meorawr]

The new ScrollBoxList as used by /etrace appears to have a few spurious and not-easily-isolated issues that cause any of the following to happen:

1. It's possible for the view to allow the user to scroll with a mousewheel input when the scroll bar and its associated buttons have been disabled. Scrolling down in such a case (such that you go beyond the end of the list) causes the contents of the view to vanish.
2. It's possible for the view to exhibit the same as the above but also not be recoverable via a scroll wheel motion; this is reliably reproduceable.
3. It's possible for the mousewheel and scroll buttons to be enabled but not actually scroll the frame when used. Dragging the scrollbar itself works however.

These both may be specific to the new event log tool which allows resizing of the window and may not be easily reproduced elsewhere.

Bug 2

This is the only reliably reproduceable one of the lot.

1. Open the event log via /etrace.
2. Click "Options" and "Apply Default Filter".
3. Click the "Filter" tab.
4. Shrink the window size such it becomes scrollable, and place the scrollbar in the middle of the bar.
5. Resize the window and grow it so that it no longer needs to scroll. The contents of the view will disappear.

Bug 1/3

These aren't easily isolated and can take some number of attempts to trigger, or may both occur at the same time.

1. Open the event log via /etrace.
2. Click "Options" and "Apply Default Filter".
3. Click the "Filter" tab.
4. If the scrollbar is enabled, scroll to the bottom of the list.
5. Resize the window so that the scrollbar is disabled and there is a very small gap underneath the last item in the list.
6. Resize the window and shrink it so that the scrollbar is re-enabled and the last item is very slightly cut-off.

After step 6 you can sometimes reproduce the following behaviour:

• Scrolling down with the mousewheel or pressing the up/down buttons will have no effect. The scrollbar itself will continue to work. Resizing the window (either to shrink or grow it) will often fix this.

If you repeat steps 5 and 6, then sometimes after step 5 if you use the mousewheel to scroll down the contents of the list will disappear despite the scroll buttons and thumb being disabled. Scrolling up will re-show the contents of the view. Resizing the frame to grow it will not fix the issue, but shrinking it until it becomes scrollable again will.

The following images demonstrate what I mean by a very small gap and cut-off for steps 5 and 6 respectively.

[Meorawr]

These should all be fixed in future builds.

[Meorawr]

To log the extra bug that was found and reported, if you perform the following:

1. Open the event trace window via /etrace
2. Click "Options" and "Apply Default Filter".
3. Click the "Filter" tab.
4. Shrink the window until a scrollbar appears.
5. Click the "x" button on any filtered event.

After clicking the "x" the filter is logically removed from the data set, but the view doesn't update until the list is scrolled or grown in size.

https://cdn.discordapp.com/attachments/827231365040701460/831933607663632435/2021-04-14_17-46-00.webm

This will also be fixed in a future build.

[Meorawr]

All issues here appear to be fixed as of 9.1.0.38394.