Package Offer don't work

[amontalban]

Hi,

I was trying to use Package Offer but found that an issue with the following SQL query:

The issue is in the file Class.RateEngine.php it's using the ratecard ID value (cc_ratecard.id) for the variable $id_rate and therefore it doesn't find the right rate for the Package Offer. The query I changed is the following:

Change the following query:

                    $query_pakages = "SELECT cc_package_offer.id, packagetype, billingtype, startday, freetimetocall ".
                                        "FROM cc_package_offer,cc_package_rate WHERE cc_package_offer.id= ".$id_cc_package_offer.
                                        " AND cc_package_offer.id = cc_package_rate.package_id AND cc_package_rate.rate_id = ".$id_rate.
                                        " ORDER BY packagetype ASC";

Change it to:

                    $query_pakages = "SELECT cc_package_offer.id, packagetype, billingtype, startday, freetimetocall ".
                                        "FROM cc_package_offer,cc_package_rate WHERE cc_package_offer.id= ".$id_cc_package_offer.
                                        " AND cc_package_offer.id = cc_package_rate.package_id".
                                        " ORDER BY packagetype ASC";

If you want I can provide a diff but can't add an attachment here.

Cheers, Andres Montalban

[areski]

it s important that we find a rate assigned to the package offer, this is how a2billing works. Edit a package offer and you will see you can assign rate to it.

FYI, you can use dpaste or gist (https://gist.github.com/) to provide a patch.

[amontalban]

Hi Areski,

Yes I added a rate to the package offer, however the value of the $id_rate variable is configured with the ratecard ID instead of the rate ID and therefore it couldn't find the rate to provide free minutes. I will try to reproduce this in the git version because I am using 1.9.3 in production.

Let me know if you need any test on my side.

Thanks!

[areski]

$id_rate = $this -> ratecard_obj[$K][6]; I agree that this contain the cc_ratecard.id, but this from the UI is the rate.id

I know the tables have wrong names and this software is a mess :)