search

Star2Billing / a2billing

A2Billing is a telecom switch and billing system capable of providing and billing a range of telecom products and services to customers such as calling card products, residential and wholesale VoIP termination, DID resale and callback services.
www.asterisk2billing.org
Other
180 stars 174 forks source link

Fix: user can enter destination without waiting initial balance prompt to finish #133

Closed andres-moya closed 8 years ago

andres-moya commented 8 years ago

Issue: If say balance after authentication enabled and customer start to enter destination before balance prompt finished he unexpectedly call wrong number (first digits missing). It affect customer experience who used to work with other cards on the market. They do allow blindly enter destination.

Fix: say balance function was modified. Now instead of going through if/then logic and saying balance it accumulate what to say, and then play prompt expecting input. If anything enetered, it stop saying and collect remaining digits. It returns this "early_destination", that is used in the IVR flow to suppress mention above issue.

areski commented 8 years ago

Nice job, I like the approach you took! I made few comments, try to improve the code style.

andres-moya commented 8 years ago

I can see only two buttons "Close and comment" and "Comment" There is no edit button... which one is correct? :)

andres-moya commented 8 years ago

awesome.