search

StarArawn / bevy_ecs_tilemap

A tilemap rendering crate for bevy which is more ECS friendly.
MIT License
943 stars 198 forks source link

Improve Tiled support #524

Closed kim-fg closed 7 months ago

kim-fg commented 7 months ago

Hi, fresh user of the project here.

I ran into a weird issue when I transitioned from sprite based environments to using this project with Tiled. The fact that there isn't a tiled helper included through, even through features, is not a very smooth experience.

My suggestion is for there to be some work put into moving the helper code from examples to the crate and leave it behind a feature flag. I did read the helper and yes, with correct logic for whether the atlas flag is used or not.

I've never worked with feature flag implementation, but I'm happy to learn and help where I can.

kim-fg commented 7 months ago

After a bit of thinking I think it would be valid to split up the example in two instead of using the atlas flag for it at all. There is like the comment says no way to make it work from a direct copy which feels unintuitive.

Is there a reason this wasn't done from the beginning?

StarArawn commented 7 months ago

I don't want to add more tiled support to this crate. I would rather have a bevy_tiled which handles loading in tiled maps. This is how bevy_ecs_ldtk works and I think that has worked well.

kim-fg commented 7 months ago

Fair enough, I'll close the issue.