StarArawn / bevy_ecs_tilemap

A tilemap rendering crate for bevy which is more ECS friendly.
MIT License
943 stars 198 forks source link

Enable `wayland` feature for `bevy` in dev #556

Closed teohhanhui closed 2 months ago

teohhanhui commented 2 months ago

Rationale:

teohhanhui commented 2 months ago

Uhh... Need to add the deps to CI...

https://github.com/bevyengine/bevy/blob/release-0.14.1/docs/linux_dependencies.md#ubuntu

teohhanhui commented 2 months ago

Oops... Missed adding the step for the clippy job...

ChristopherBiscardi commented 2 months ago

https://github.com/bevyengine/bevy/pull/10792#issuecomment-2239837897 states that

Defaulting to Wayland will break Bevy for Wayland users with no access to Vulkan drivers.

I largely don't have an opinion on doing this for dev. It looks like the current state of things is we either potentially break one group of users or another group of users (until bevy merges the fix upstream), but wayland is the future so I'm a soft +1.

Would like to get thoughts from @rparrett though.

teohhanhui commented 2 months ago

Defaulting to Wayland will break Bevy for Wayland users with no access to Vulkan drivers.

Actually no, it's already broken. If you're on Wayland, and have no Vulkan driver, nothing would help at this time. Every possible combination is broken.

XWayland + OpenGL does not work: https://github.com/bevyengine/bevy/issues/13753#issuecomment-2167562087 and https://github.com/bevyengine/bevy/issues/8788#issuecomment-1742192359

Wayland + OpenGL does not work: https://github.com/bevyengine/bevy/issues/13923

ChristopherBiscardi commented 2 months ago

merging then, we can re-evaluate if bevy changes upstream. thanks @teohhanhui !