search

StarArawn / bevy_tiled

A plugin for rendering tiled maps.
MIT License
151 stars 40 forks source link

Update for future bevy 0.5 / bevy master #33

Closed rparrett closed 3 years ago

rparrett commented 3 years ago

Opening this PR for discussion / discoverability.

I started from Kurble's fork over https://github.com/StarArawn/bevy_tiled/pull/30 because of this: https://github.com/StarArawn/bevy_tiled/commit/014b8fdfa1588137d6c420f428b3cb3f6731194b and it seems to work fine, but there are other differences and I don't know enough about bevy internals to say more.

This might save some effort if you or someone else is trying to get bevy_tiled working with bevy master and bevy_webgl2.

rparrett commented 3 years ago

rs-tiled merged my PR, so it is now wasm-compatible in the same way my fork was. So I have un-forked it in this branch.

https://github.com/mattyhall/rs-tiled/commit/8d25d2510fd4f63d1b920126c5db4ab210eb9ad5

rparrett commented 3 years ago

I have sort of accidentally turned this fork into one that's tracking bevy master, so I updated the title/body to reflect that.

If you'd welcome separate PRs for the webgl2 fixes or a PR that's compatible with bevy 0.4, I'm more equipped to handle that sort of thing than when I originally opened this.

rparrett commented 3 years ago

Going to close this and open a new PR