Fix minor issues in file creation return handling

StarChart-Labs / corona-ide

A exploratory project to build a lighter, simpler Java IDE - or learn trying!

Eclipse Public License 1.0

3 stars 1 forks source link

Fix minor issues in file creation return handling #23

Closed romeara closed 7 years ago

romeara commented 7 years ago

Fix two classes of issues:

unnecessary null check
ignoring boolean return of the createNewFile method

The application now throws an exception if file creation fails

codecov-io commented 7 years ago

Current coverage is 90.30% (diff: 44.44%)

Merging #23 into master will decrease coverage by 2.00%

@@             master        #23   diff @@
==========================================
  Files             9          9          
  Lines           195        196     +1   
  Methods           0          0          
  Messages          0          0          
  Branches         25         25          
==========================================
- Hits            180        177     -3   
- Misses            5          8     +3   
- Partials         10         11     +1

Powered by Codecov. Last update 15db98a...96ab601

nickavv commented 7 years ago

Coverage went down huh?

romeara commented 7 years ago

Yeah - I only added a couple lines, and I can't figure out how to force Java to fail the createNewFile call to hit them