StarChart-Labs / corona-ide

A exploratory project to build a lighter, simpler Java IDE - or learn trying!
Eclipse Public License 1.0
3 stars 1 forks source link

Remove migrate - Unnecessary complexity without current known use cases #39

Closed romeara closed 7 years ago

romeara commented 7 years ago

Datastore.migrate() was added originally to cover a possible data-migration use case. However, this case can be addressed in other ways, and the inclusion of this method without strong supporting use-cases at this time is introducing unjustified overhead

codecov[bot] commented 7 years ago

Codecov Report

Merging #39 into master will decrease coverage by 1.54%. The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #39      +/-   ##
============================================
- Coverage     87.02%   85.47%   -1.55%     
+ Complexity      108      103       -5     
============================================
  Files            18       18              
  Lines           370      365       -5     
  Branches         34       33       -1     
============================================
- Hits            322      312      -10     
- Misses           34       38       +4     
- Partials         14       15       +1
Impacted Files Coverage Δ Complexity Δ
...va/com/coronaide/core/datastore/JsonDatastore.java 100% <ø> (ø) 4 <0> (-1) :arrow_down:
.../coronaide/core/service/impl/DatastoreService.java 79.27% <100%> (-4.8%) 16 <0> (-4)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 141515c...6ab23a3. Read the comment docs.