StarChart-Labs / corona-ide

A exploratory project to build a lighter, simpler Java IDE - or learn trying!
Eclipse Public License 1.0
3 stars 1 forks source link

52: delete project #54

Closed nickavv closed 7 years ago

nickavv commented 7 years ago

Right click on a project in the list and you can delete it. Brings up a confirmation dialog which gives you the option to also remove the files from disk (similar to Eclipse's cause I actually like how they present that choice)

capture

codecov[bot] commented 7 years ago

Codecov Report

Merging #54 into master will decrease coverage by 3.3%. The diff coverage is 46.51%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #54      +/-   ##
============================================
- Coverage      81.5%   78.19%   -3.31%     
- Complexity      122      125       +3     
============================================
  Files            23       25       +2     
  Lines           438      477      +39     
  Branches         32       33       +1     
============================================
+ Hits            357      373      +16     
- Misses           68       90      +22     
- Partials         13       14       +1
Impacted Files Coverage Δ Complexity Δ
...ava/com/coronaide/ui/custom/AlertWithCheckbox.java 0% <0%> (ø) 0 <0> (?)
...va/com/coronaide/ui/controller/MainController.java 34.69% <100%> (ø) 4 <1> (ø) :arrow_down:
.../java/com/coronaide/ui/custom/ProjectListCell.java 66.66% <66.66%> (ø) 3 <3> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 389b7c3...0b6e6a4. Read the comment docs.

nickavv commented 7 years ago

@romeara I got that stuff out of the lambda, actually took my extension of the ListCell class and promoted it to a real class that extends ListCell. This revealed to me the actual places things were supposed to be accessible to each other that was hidden by the magic of lambdas, so I fixed those too.

Finally, rather than call my "showAllProjects()" method every time I do anything to refresh the project list view I started using the ObservableList for its real purpose (modifying the list itself refreshes the view. I was making unnecessary calls to project service and creating new observablelists each time, so this is much better)