StarChart-Labs / flare-plugins

Gradle plug-ins with opinionated defaults to allow streamlined, consistent operations
MIT License
1 stars 0 forks source link

GH-23 Fix issue where stale dependency cache could be used across builds #25

Closed romeara closed 4 years ago

romeara commented 4 years ago

Change caching logic for loaded dependency information to include time modified, to prevent stale cached content from being used when changes are made between builds. This situation could arise due to the Gradle Daemon re-using class loaders between builds

codecov[bot] commented 4 years ago

Codecov Report

Merging #25 into master will decrease coverage by 0.37%. The diff coverage is 80%.

@@             Coverage Diff              @@
##             master      #25      +/-   ##
============================================
- Coverage     85.04%   84.67%   -0.38%     
+ Complexity      252      251       -1     
============================================
  Files            25       25              
  Lines           749      757       +8     
  Branches         53       53              
============================================
+ Hits            637      641       +4     
- Misses           91       93       +2     
- Partials         21       23       +2
Impacted Files Coverage Δ Complexity Δ
...abs/flare/plugins/model/DependencyConstraints.java 86.11% <80%> (-6.75%) 10 <3> (ø)
...rchartlabs/flare/plugins/model/ConstraintFile.java 96.15% <0%> (-3.85%) 12% <0%> (-1%)
blackduck-copilot[bot] commented 4 years ago

Black Duck Security Report

Merging #25 into master will not change security risk.

Click here to see full report

romeara commented 4 years ago

Yeah, am displeased with Gradle for necessitating it, but didn't want to reload dependencies in every project